Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24578 )
Change subject: KUDU-3800 Add diff-scan option to return unobservable rows ...................................................................... Patch Set 15: Code-Review+1 (1 comment) Apart from the outstanding comments, the change looks good to me. Just for the record - at some point, we would also need to enforce a server-side (preferably inside HandleScanAtSnapshot()) check to ensure migration times is older than snap_start_timestamp before proceeding with the scan. http://gerrit.cloudera.org:8080/#/c/24578/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24578/15//COMMIT_MSG@20 PS15, Line 20: (and whose delete was propagated) Did you mean 'not' propagated? Better to just remove this line to avoid any confusion. -- To view, visit http://gerrit.cloudera.org:8080/24578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d0727fb2b89c727c669ec218e3bb8594336359a Gerrit-Change-Number: 24578 Gerrit-PatchSet: 15 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 28 Aug 2026 11:15:06 +0000 Gerrit-HasComments: Yes
