Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24578 )
Change subject: KUDU-3800 Add diff-scan option to return unobservable rows ...................................................................... Patch Set 16: (2 comments) Overall looks good to me. Consider addressing a tiny formatting nit after recent renaming. Also, it seems IWYU isn't happy yet: >>> Fixing #includes in >>> '/home/jenkins-slave/workspace/build_and_test/src/kudu/client/scan_token-test.cc' @@ -23,6 +23,7 @@ #include <initializer_list> #include <map> #include <memory> +#include <ostream> #include <string> #include <thread> #include <type_traits> IWYU would have edited 1 files on your behalf. http://gerrit.cloudera.org:8080/#/c/24578/15/src/kudu/tablet/diff_scan-test.cc File src/kudu/tablet/diff_scan-test.cc: http://gerrit.cloudera.org:8080/#/c/24578/15/src/kudu/tablet/diff_scan-test.cc@566 PS15, Line 566: > It is stored as -2 as per below Thanks a lot for adding the note! http://gerrit.cloudera.org:8080/#/c/24578/16/src/kudu/tablet/diff_scan-test.cc File src/kudu/tablet/diff_scan-test.cc: http://gerrit.cloudera.org:8080/#/c/24578/16/src/kudu/tablet/diff_scan-test.cc@265 PS16, Line 265: style nit for here and elsewhere after the recent DoScan --> DoDiffScan renaming: wrong indent -- To view, visit http://gerrit.cloudera.org:8080/24578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d0727fb2b89c727c669ec218e3bb8594336359a Gerrit-Change-Number: 24578 Gerrit-PatchSet: 16 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 28 Aug 2026 22:04:11 +0000 Gerrit-HasComments: Yes
