Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24578 )
Change subject: KUDU-3800 Add diff-scan option to return unobservable rows ...................................................................... Patch Set 17: Code-Review+2 (2 comments) LGTM! Feel free to address the nits in a separate change. http://gerrit.cloudera.org:8080/#/c/24578/17/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/24578/17/src/kudu/client/client.h@3136 PS17, Line 3136: The values are kept in sync : /// with the wire enum kudu::RowVisibility so the same integer values : /// mean the same thing on both sides nit: See if you can add static_assert to enforce this. This is to avoid any issues arising due to re-numbering of enum due to any reason. Address this in a separate change if you want to. http://gerrit.cloudera.org:8080/#/c/24578/17/src/kudu/tablet/diff_scan-test.cc File src/kudu/tablet/diff_scan-test.cc: http://gerrit.cloudera.org:8080/#/c/24578/17/src/kudu/tablet/diff_scan-test.cc@51 PS17, Line 51: namespace kudu { : namespace tablet { : class Tablet; : } // namespace tablet : } // namespace kudu nit: Any use for this? -- To view, visit http://gerrit.cloudera.org:8080/24578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d0727fb2b89c727c669ec218e3bb8594336359a Gerrit-Change-Number: 24578 Gerrit-PatchSet: 17 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 31 Aug 2026 13:10:54 +0000 Gerrit-HasComments: Yes
