Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24790 )
Change subject: [metrics] Support quantile selection in /metrics_prometheus ...................................................................... Patch Set 2: -Code-Review (1 comment) http://gerrit.cloudera.org:8080/#/c/24790/2/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/24790/2/src/kudu/util/metrics.h@500 PS2, Line 500: std::string Ah, I almost missed this most important piece of feedback: what if we store the pointers to the statically allocated string literals here instead of using std::string? We populate these from the set of known quantile tags only, right? In other words, I'd think of using std::array<const char*, kNumHistogramQuantiles> instead of std::array<std::string, kNumHistogramQuantiles> in an attempt avoid extra memory allocations/deallocations. Instead of empty strings, non-valid elements would become nullptr instead. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/24790 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01b48aa30f26f2a7efcd842bf6512a023cbf90ff Gerrit-Change-Number: 24790 Gerrit-PatchSet: 2 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Comment-Date: Tue, 08 Sep 2026 18:43:10 +0000 Gerrit-HasComments: Yes
