Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24790 )
Change subject: [metrics] Support quantile selection in /metrics_prometheus ...................................................................... Patch Set 4: Code-Review+2 (1 comment) This looks good to me! Thank you for implementing this feature. http://gerrit.cloudera.org:8080/#/c/24790/4/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/24790/4/src/kudu/util/metrics.cc@1483 PS4, Line 1483: [](const char* q) { return q == nullptr; }); nit: UUIC, the opt.quantiles are populated starting with the very first element, and perhaps it'd be enough to check whether quantiles[0] is nullptr or not -- it's not a big deal and it's possible to address it in a follow-up changelist, if necessary -- To view, visit http://gerrit.cloudera.org:8080/24790 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01b48aa30f26f2a7efcd842bf6512a023cbf90ff Gerrit-Change-Number: 24790 Gerrit-PatchSet: 4 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Comment-Date: Wed, 09 Sep 2026 14:06:55 +0000 Gerrit-HasComments: Yes
