Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24851 )
Change subject: KUDU-3804: Fix symbol hiding for protobuf well-known types ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24851/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24851/1//COMMIT_MSG@22 PS1, Line 22: : Change-Id: I64f88bbfab6a709ae31fb18ed97cfc58cb8b647d : Assisted-By: Claude Sonnet > While you are at this, did you have a chance to run ./bin/client_symbol-tes I don't fully understand what's going on. Addressing a symptom here, and I've narrowed it to hiding descriptor_table specifically. client_symbol-test.sh passes without this patch and with it. Without it shows Skipping non-strong and non-global symbol 'descriptor_table_google_2fprotobuf_2fany_2eproto' Skipping non-strong and non-global symbol 'descriptor_table_google_2fprotobuf_2fdescriptor_2eproto' Skipping non-strong and non-global symbol 'descriptor_table_google_2fprotobuf_2fsource_5fcontext_2eproto' Skipping non-strong and non-global symbol 'descriptor_table_google_2fprotobuf_2ftype_2eproto' Skipping non-strong and non-global symbol 'descriptor_table_google_2fprotobuf_2fwrappers_2eproto' Skipping non-strong and non-global symbol 'descriptor_table_google_2fprotobuf_2fany_2eproto_getter()' Skipping non-strong and non-global symbol 'descriptor_table_google_2fprotobuf_2ftype_2eproto_getter()' Skipping non-strong and non-global symbol 'descriptor_table_google_2fprotobuf_2fwrappers_2eproto_getter()' Skipping non-strong and non-global symbol 'descriptor_table_google_2fprotobuf_2fdescriptor_2eproto_getter()' Skipping non-strong and non-global symbol 'descriptor_table_google_2fprotobuf_2fsource_5fcontext_2eproto_getter()' ... Skipping non-strong and non-global symbol 'TableStruct_google_2fprotobuf_2fany_2eproto::offsets' Skipping non-strong and non-global symbol 'TableStruct_google_2fprotobuf_2ftype_2eproto::offsets' Skipping non-strong and non-global symbol 'TableStruct_google_2fprotobuf_2fwrappers_2eproto::offsets' Skipping non-strong and non-global symbol 'TableStruct_google_2fprotobuf_2fdescriptor_2eproto::offsets' Skipping non-strong and non-global symbol 'TableStruct_google_2fprotobuf_2fsource_5fcontext_2eproto::offsets' With it, the descriptor_table symbols are removed, as expected. -- To view, visit http://gerrit.cloudera.org:8080/24851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64f88bbfab6a709ae31fb18ed97cfc58cb8b647d Gerrit-Change-Number: 24851 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 15 Sep 2026 20:05:47 +0000 Gerrit-HasComments: Yes
