David Ribeiro Alves has posted comments on this change. Change subject: Move the maintenance manager to util ......................................................................
Patch Set 1: (16 comments) This change is required as we'll need a server-wide MM for the result tracker. Added comment in that regard to the commit message. http://gerrit.cloudera.org:8080/#/c/3656/1//COMMIT_MSG Commit Message: PS1, Line 9: it's > nit: its Done Line 10: It doesn't change the namespace (kudu::) since that would be more involved. > But isn't kudu:: the right namespace for something in util? Done http://gerrit.cloudera.org:8080/#/c/3656/1/src/kudu/integration-tests/full_stack-insert-scan-test.cc File src/kudu/integration-tests/full_stack-insert-scan-test.cc: Line 40: #include "kudu/util/maintenance_manager.h" > Nit: resort. Done http://gerrit.cloudera.org:8080/#/c/3656/1/src/kudu/master/master.cc File src/kudu/master/master.cc: Line 39: #include "kudu/util/maintenance_manager.h" > Nit: resort. Done http://gerrit.cloudera.org:8080/#/c/3656/1/src/kudu/tablet/CMakeLists.txt File src/kudu/tablet/CMakeLists.txt: Line 36: ../util/maintenance_manager.cc > What's this doing here? The maintenance manager is now part of libkudu_util clion refactor. Done Line 101: ADD_KUDU_TEST(maintenance_manager-test) > The test should be moved too. Done http://gerrit.cloudera.org:8080/#/c/3656/1/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: Line 48: #include "kudu/util/maintenance_manager.h" > Nit: resort. Done http://gerrit.cloudera.org:8080/#/c/3656/1/src/kudu/tablet/tablet_peer-test.cc File src/kudu/tablet/tablet_peer-test.cc: Line 35: #include "kudu/util/maintenance_manager.h" > Nit: resort. Done http://gerrit.cloudera.org:8080/#/c/3656/1/src/kudu/tablet/tablet_peer_mm_ops.cc File src/kudu/tablet/tablet_peer_mm_ops.cc: Line 27: #include "kudu/util/maintenance_manager.h" > Nit: resort. Done http://gerrit.cloudera.org:8080/#/c/3656/1/src/kudu/tserver/mini_tablet_server.cc File src/kudu/tserver/mini_tablet_server.cc: Line 34: #include "kudu/util/maintenance_manager.h" > Nit: resort. Done http://gerrit.cloudera.org:8080/#/c/3656/1/src/kudu/tserver/tablet_server-test-base.h File src/kudu/tserver/tablet_server-test-base.h: Line 43: #include "kudu/util/maintenance_manager.h" > Nit: resort. Done http://gerrit.cloudera.org:8080/#/c/3656/1/src/kudu/tserver/tablet_server.cc File src/kudu/tserver/tablet_server.cc: Line 30: #include "kudu/util/maintenance_manager.h" > Nit: resort. Done http://gerrit.cloudera.org:8080/#/c/3656/1/src/kudu/tserver/tserver-path-handlers.cc File src/kudu/tserver/tserver-path-handlers.cc: Line 35: #include "kudu/util/maintenance_manager.h" > Nit: resort. Done http://gerrit.cloudera.org:8080/#/c/3656/1/src/kudu/util/maintenance_manager-test.cc File src/kudu/util/maintenance_manager-test.cc: Line 25: #include "maintenance_manager.h" > Should be kudu/util, and resort. Done http://gerrit.cloudera.org:8080/#/c/3656/1/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: Line 18: #include "maintenance_manager.h" > Nit: kudu/util. Done http://gerrit.cloudera.org:8080/#/c/3656/1/src/kudu/util/maintenance_manager.h File src/kudu/util/maintenance_manager.h: Line 17: #pragma once > Nit: separate from the license with an empty line. Done -- To view, visit http://gerrit.cloudera.org:8080/3656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf072d443ac3d069bda15b9dc0f8c442b9ac5c0 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
