David Ribeiro Alves has posted comments on this change. Change subject: Move the maintenance manager to util ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3656/3/src/kudu/util/maintenance_manager.h File src/kudu/util/maintenance_manager.h: Line 243: void GetMaintenanceManagerStatusDump(MaintenanceManagerStatusPB* out_pb); > Since this is a pointer, you don't even need to include maintenance_manager But then I'll have to fwd declare it in a bunch of places. Since this is only a code move mind if I drop this? -- To view, visit http://gerrit.cloudera.org:8080/3656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf072d443ac3d069bda15b9dc0f8c442b9ac5c0 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
