jerryshao commented on a change in pull request #289:
URL: https://github.com/apache/incubator-livy/pull/289#discussion_r446820287
##########
File path:
scala-api/src/main/scala/org/apache/livy/scalaapi/ScalaJobHandle.scala
##########
@@ -190,6 +190,19 @@ class ScalaJobHandle[T] private[livy] (jobHandle:
JobHandle[T]) extends Future[T
getJavaFutureResult(jobHandle, atMost)
this
}
+
+ // These two methods must be implemented in Scala 2.12. They're implemented
as a no-op here
Review comment:
Yes, the comments seems confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
