> On April 20, 2015, 5:18 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp, line 258 > > <https://reviews.apache.org/r/32198/diff/3/?file=903041#file903041line258> > > > > How about also checking for a larger array? > > Alexander Rojas wrote: > What can be considered larger? 5 elements, 10 elements, 100 elements? I > personally don't think it makes any difference for the equality operator, > since the comparison is still linear. > > Till Toenshoff wrote: > Niklas, do you have a suggestion here or shall we drop it?
He clarified the reason why to use 5 elements, I haven't had time to fix it however. Will do tomorrow. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32198/#review80559 ----------------------------------------------------------- On April 21, 2015, 2:06 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32198/ > ----------------------------------------------------------- > > (Updated April 21, 2015, 2:06 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, Joerg Schad, > Marco Massenzio, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-2510 > https://issues.apache.org/jira/browse/MESOS-2510 > > > Repository: mesos > > > Description > ------- > > For consistency, adds a non equal operator to the json objects. > > It also adds tests to the equality operators. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp > 334c898906018be6e663f53815abbe047806b95c > 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp > f60d1bbe60f2e2b6460c06bba98e8b85ebb6a3f9 > > Diff: https://reviews.apache.org/r/32198/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >