reviews
Thread
Date
Earlier messages
Later messages
Messages by Date
2024/07/25
Review Request 75109: [ebpf] Correct ebpf deny block behavior
Jason Zhou
2024/07/24
Re: Review Request 75099: [cgroups2] Add access check to CgroupDeviceAccess
Benjamin Mahler
2024/07/24
Re: Review Request 75099: [cgroups2] Add access check to CgroupDeviceAccess
Jason Zhou
2024/07/24
Re: Review Request 75106: [devices] Add Selector::encompasses
Benjamin Mahler
2024/07/24
Re: Review Request 75107: [devices] Add helper to find overlapping Access
Benjamin Mahler
2024/07/24
Re: Review Request 75106: [devices] Add Selector::encompasses
Jason Zhou
2024/07/24
Re: Review Request 75107: [devices] Add helper to find overlapping Access
Jason Zhou
2024/07/24
Review Request 75107: [cgroups2] Add helper to find overlapping Access
Jason Zhou
2024/07/24
Review Request 75106: [cgroups2] Add Selector::encompasses
Jason Zhou
2024/07/23
Re: Review Request 75102: [cgroups2] Let DeviceManager attach ebpf program
Benjamin Mahler
2024/07/23
Review Request 75102: [cgroups2] Let DeviceManager attach ebpf program
Jason Zhou
2024/07/23
Re: Review Request 75099: [cgroups2] Add access check to CgroupDeviceAccess
Jason Zhou
2024/07/23
Re: Review Request 75099: [cgroups2] Add access check to CgroupDeviceAccess
Jason Zhou
2024/07/22
Re: Review Request 75006: [cgroups2] Introduce the DeviceManagerProcess
Benjamin Mahler
2024/07/22
Re: Review Request 75099: [cgroups2] Add access check to CgroupDeviceAccess
Mesos Reviewbot
2024/07/22
Re: Review Request 75016: [cgroups2] pass device manager to controllers & cgroups2 isolator
Mesos Reviewbot
2024/07/22
Review Request 75099: [cgroups2] Add access check to CgroupDeviceAccess
Jason Zhou
2024/07/22
Re: Review Request 75006: [cgroups2] Introduce the DeviceManagerProcess
Jason Zhou
2024/07/22
Re: Review Request 75016: [cgroups2] pass device manager to controllers & cgroups2 isolator
Mesos Reviewbot
2024/07/22
Re: Review Request 75006: [cgroups2] Introduce the DeviceManagerProcess
Jason Zhou
2024/07/19
Re: Review Request 75016: [cgroups2] pass device manager to controllers & cgroups2 isolator
Jason Zhou
2024/07/19
Re: Review Request 75016: [cgroups2] pass device manager to controllers & cgroups2 isolator
Jason Zhou
2024/07/19
Re: Review Request 75016: [cgroups2] pass device manager to controllers & cgroups2 isolator
Mesos Reviewbot
2024/07/19
Re: Review Request 75006: [cgroups2] Introduce the DeviceManagerProcess
Jason Zhou
2024/07/19
Re: Review Request 75096: [cgroups] Add helper functions for Entry
Benjamin Mahler
2024/07/18
Re: Review Request 75096: [cgroups] Add helper functions for Entry
Mesos Reviewbot
2024/07/18
Re: Review Request 75096: [cgroups] Add helper functions for Entry
Benjamin Mahler
2024/07/18
Re: Review Request 75096: [cgroups] Add helper functions for Entry
Mesos Reviewbot
2024/07/18
Review Request 75096: [cgroups] Add helper functions for Entry
Jason Zhou
2024/07/17
Re: Review Request 75016: [cgroups2] pass device manager to controllers & cgroups2 isolator
Mesos Reviewbot
2024/07/17
Re: Review Request 75006: [cgroups2] Introduce the DeviceManagerProcess
Jason Zhou
2024/07/17
Re: Review Request 75006: [cgroups2] Introduce the DeviceManagerProcess
Jason Zhou
2024/07/17
Re: Review Request 75006: [cgroups2] Introduce the DeviceManagerProcess
Jason Zhou
2024/07/16
Re: Review Request 75091: [build] use clang-14 for non ubuntu 16.04 targets in docker-build.sh
Benjamin Mahler
2024/07/16
Re: Review Request 75057: [link] Work around apparent MAC address bug
Benjamin Mahler
2024/07/16
Re: Review Request 75091: [build] use clang-14 for non ubuntu 16.04 targets in docker-build.sh
Mesos Reviewbot
2024/07/16
Re: Review Request 75016: [cgroups2] pass device manager to controllers & cgroups2 isolator
Mesos Reviewbot
2024/07/16
Review Request 75091: [build] use clang-14 for non ubuntu 16.04 targets in docker-build.sh
Jason Zhou
2024/07/15
Re: Review Request 75090: [veth] provide the ability to set veth peer link MAC address on creation
Benjamin Mahler
2024/07/15
Re: Review Request 75090: [veth] provide the ability to set veth peer link MAC address on creation
Jason Zhou
2024/07/15
Re: Review Request 75090: [veth] provide the ability to set veth peer link MAC address on creation
Jason Zhou
2024/07/15
Re: Review Request 75090: [veth] provide the ability to set veth peer link MAC address on creation
Benjamin Mahler
2024/07/15
Re: Review Request 75090: [veth] provide the ability to set veth peer link MAC address on creation
Jason Zhou
2024/07/15
Re: Review Request 75090: [veth] provide the ability to set veth peer link MAC address on creation
Jason Zhou
2024/07/15
Review Request 75090: [veth] provide the ability to set veth peer link MAC address on creation
Jason Zhou
2024/07/15
Re: Review Request 75088: [jenkins] create dockerfile compatible with 22.04 build
Jason Zhou
2024/07/15
Re: Review Request 75089: [build] correct ubuntu version on comment
Benjamin Mahler
2024/07/15
Re: Review Request 75086: [veth] Avoid udev race condtion on systems with systemd version > 242
Benjamin Mahler
2024/07/15
Re: Review Request 75089: [build] correct ubuntu version on comment
Jason Zhou
2024/07/15
Review Request 75089: [build] correct ubunut version on comment
Jason Zhou
2024/07/15
Re: Review Request 75087: [veth] add todo to set mac address on create for peer link
Benjamin Mahler
2024/07/15
Re: Review Request 75088: [jenkins] create dockerfile compatible with 22.04 build
Benjamin Mahler
2024/07/15
Re: Review Request 75088: [jenkins] create dockerfile compatible with 22.04 build
Jason Zhou
2024/07/15
Review Request 75088: [jenkins] create dockerfile compatible with 22.04 build
Jason Zhou
2024/07/15
Re: Review Request 75087: [veth] add todo to set mac address on create for peer link
Jason Zhou
2024/07/15
Re: Review Request 75086: [veth] Avoid udev race condtion on systems with systemd version > 242
Jason Zhou
2024/07/15
Re: Review Request 75086: [veth] Avoid udev race condtion on systems with systemd version > 242
Jason Zhou
2024/07/15
Re: Review Request 75086: [veth] Avoid udev race condtion on systems with systemd version > 242
Jason Zhou
2024/07/15
Re: Review Request 75087: [veth] add todo to set mac address on create for peer link
Jason Zhou
2024/07/14
Re: Review Request 75086: [veth] Avoid udev race condtion on systems with systemd version > 242
Benjamin Mahler
2024/07/14
Re: Review Request 75087: [veth] add todo to set mac address on create for peer link
Benjamin Mahler
2024/07/14
Re: Review Request 75080: [ebpf] Prevent conflicting ebpf files from attaching on the same cgroup
Benjamin Mahler
2024/07/12
Re: Review Request 75087: [veth] add todo to set mac address on create for peer link
Mesos Reviewbot
2024/07/12
Re: Review Request 75086: [veth] Avoid udev race condtion on systems with systemd version > 242
Mesos Reviewbot
2024/07/12
Review Request 75087: [veth] add todo to set mac address on create for peer link
Jason Zhou
2024/07/12
Re: Review Request 75086: [veth] Avoid udev race condtion on systems with systemd version > 242
Jason Zhou
2024/07/12
Re: Review Request 75086: [veth] Avoid udev race condtion on systems with systemd version > 242
Mesos Reviewbot
2024/07/12
Review Request 75086: [veth] Avoid udev race condtion on systems with systemd version > 242
Jason Zhou
2024/07/11
Re: Review Request 75016: [cgroups2] pass device manager to controllers & cgroups2 isolator
Mesos Reviewbot
2024/07/11
Re: Review Request 75016: [cgroups2] pass device manager to controllers & cgroups2 isolator
Mesos Reviewbot
2024/07/11
Re: Review Request 75081: [cgroups2] make cgroups2::path take both absolute and relative paths
Benjamin Mahler
2024/07/11
Re: Review Request 75080: [ebpf] Prevent conflicting ebpf files from attaching on the same cgroup
Jason Zhou
2024/07/11
Re: Review Request 75081: [cgroups2] make cgroups2::path take both absolute and relative paths
Jason Zhou
2024/07/11
Re: Review Request 75083: [ebpf] helper function for getting bpf file descriptor by program id
Benjamin Mahler
2024/07/11
Re: Review Request 75016: [cgroups2] pass device manager to controllers & cgroups2 isolator
Mesos Reviewbot
2024/07/11
Re: Review Request 75080: [ebpf] Prevent conflicting ebpf files from attaching on the same cgroup
Jason Zhou
2024/07/11
Re: Review Request 75080: [ebpf] Prevent conflicting ebpf files from attaching on the same cgroup
Jason Zhou
2024/07/11
Review Request 75083: [ebpf] helper function for getting bpf file descriptor by program id
Jason Zhou
2024/07/10
Re: Review Request 75081: [cgroups2] make cgroups2::path take both absolute and relative paths
Mesos Reviewbot
2024/07/10
Review Request 75081: [cgroups2] make cgroups2::path take both absolute and relative paths
Jason Zhou
2024/07/10
Re: Review Request 75016: [cgroups2] pass device manager to controllers & cgroups2 isolator
Mesos Reviewbot
2024/07/10
Re: Review Request 75080: [ebpf] Prevent conflicting ebpf files from attaching on the same cgroup
Benjamin Mahler
2024/07/10
Re: Review Request 75026: [cgroups2] Fix allow deny semantics for device access.
Benjamin Mahler
2024/07/10
Re: Review Request 75026: [cgroups2] Fix allow deny semantics for device access.
Benjamin Mahler
2024/07/10
Review Request 75080: [ebpf] Prevent conflicting ebpf files from attaching on the same cgroup
Jason Zhou
2024/07/09
Re: Review Request 75016: [cgroups2] pass device manager to controllers & cgroups2 isolator
Mesos Reviewbot
2024/07/09
Re: Review Request 75026: [cgroups2] Fix allow deny semantics for device access.
Jason Zhou
2024/07/09
Re: Review Request 75016: [cgroups2] pass device manager to controllers & cgroups2 isolator
Mesos Reviewbot
2024/07/09
Re: Review Request 75006: [cgroups2] Introduce the DeviceManagerProcess
Jason Zhou
2024/07/08
Re: Review Request 75016: [cgroups2] pass device manager to controllers & cgroups2 isolator
Mesos Reviewbot
2024/07/08
Re: Review Request 75026: [cgroups2] update device configuration EBPF program generator
Jason Zhou
2024/07/08
Re: Review Request 75026: [cgroups2] update device configuration EBPF program generator
Jason Zhou
2024/07/08
Re: Review Request 75016: [cgroups2] pass device manager to controllers & cgroups2 isolator
Mesos Reviewbot
2024/07/03
Re: Review Request 75016: [cgroups2] pass device manager to controllers & cgroups2 isolator
Mesos Reviewbot
2024/07/03
Re: Review Request 75026: [cgroups2] update device configuration EBPF program generator
Jason Zhou
2024/07/03
Re: Review Request 75016: [cgroups2] pass device manager to controllers & cgroups2 isolator
Mesos Reviewbot
2024/07/03
Re: Review Request 75026: [cgroups2] update device configuration EBPF program generator
Jason Zhou
2024/07/02
Re: Review Request 75075: [build] remove TLS 1.0 and 1.1 tests
Benjamin Mahler
2024/07/02
Re: Review Request 75075: [build] remove TLS 1.0 and 1.1 tests
Mesos Reviewbot
2024/07/02
Review Request 75075: [build] remove TLS 1.0 and 1.1 tests
Jason Zhou
2024/07/02
Re: Review Request 75016: [cgroups2] pass device manager to controllers & cgroups2 isolator
Mesos Reviewbot
2024/07/02
Re: Review Request 75026: [cgroups2] update device configuration EBPF program generator
Benjamin Mahler
2024/07/02
Re: Review Request 75026: [cgroups2] update device configuration EBPF program generator
Benjamin Mahler
2024/07/02
Re: Review Request 75070: [build] fix 'incomplete definition of type 'struct bio_st'' error in libevent-enabled cmake builds on ubuntu 20.04
Benjamin Mahler
2024/07/02
Re: Review Request 75066: [build] fix docker-build.sh failing to compile with distcheck
Benjamin Mahler
2024/07/02
Re: Review Request 75070: [build] fix 'incomplete definition of type 'struct bio_st'' error in libevent-enabled cmake builds on ubuntu 20.04
Jason Zhou
2024/07/02
Re: Review Request 75066: [build] fix docker-build.sh failing to compile with distcheck
Jason Zhou
2024/07/02
Re: Review Request 75066: [build] fix docker-build.sh failing to compile with distcheck
Benjamin Mahler
2024/07/02
Re: Review Request 75066: [build] fix docker-build.sh failing to compile with distcheck
Jason Zhou
2024/07/02
Re: Review Request 75070: [build] fix 'incomplete definition of type 'struct bio_st'' error in libevent-enabled cmake builds on ubuntu 20.04
Jason Zhou
2024/07/02
Re: Review Request 75063: [build] use ubuntu:20.04 for verify-review
Benjamin Mahler
2024/07/02
Re: Review Request 75066: [build] fix docker-build.sh failing to compile with distcheck
Benjamin Mahler
2024/07/02
Re: Review Request 75062: [build] fix distcheck for ubuntu20.04
Benjamin Mahler
2024/06/28
Review Request 75070: [build] fix 'incomplete definition of type 'struct bio_st'' error in libevent-enabled cmake builds on ubuntu 20.04
Jason Zhou
2024/06/27
Re: Review Request 75066: [build] fix docker-build.sh failing to compile with distcheck
Jason Zhou
2024/06/26
Re: Review Request 75062: [build] fix distcheck for ubuntu20.04
Jason Zhou
2024/06/26
Re: Review Request 75063: [build] use ubuntu:20.04 for verify-review
Jason Zhou
2024/06/25
Re: Review Request 75063: [build] use ubuntu:20.04 for verify-review
Benjamin Mahler
2024/06/25
Re: Review Request 75062: [build] fix distcheck for ubuntu20.04
Benjamin Mahler
2024/06/25
Re: Review Request 75066: [build] fix docker-build.sh failing to compile with distcheck
Jason Zhou
2024/06/25
Review Request 75066: [build] fix docker-build.sh failing to compile with distcheck
Jason Zhou
2024/06/25
Re: Review Request 75062: [build] fix distcheck for ubuntu20.04
Jason Zhou
2024/06/25
Re: Review Request 75062: [build] fix distcheck for ubuntu20.04
Jason Zhou
2024/06/25
Re: Review Request 75063: [build] use ubuntu:20.04 for verify-review
Jason Zhou
2024/06/24
Re: Review Request 75063: [build] use ubuntu:20.04 for verify-review
Benjamin Mahler
2024/06/24
Re: Review Request 75062: [build] fix distcheck for ubuntu20.04
Benjamin Mahler
2024/06/24
Review Request 75063: [build] use ubuntu:20.04 for verify-review
Jason Zhou
2024/06/24
Review Request 75062: [build] fix distcheck for ubuntu20.04
Jason Zhou
2024/06/19
Re: Review Request 75057: [link] Work around apparent MAC address bug
Jason Zhou
2024/06/19
Re: Review Request 75057: [link] Work around apparent MAC address bug
Benjamin Mahler
2024/06/19
Re: Review Request 75058: [mac] support constructing net::MAC object from sa_data char[14] array
Benjamin Mahler
2024/06/18
Review Request 75058: [mac] support constructing net::MAC object from sa_data char[14] array
Jason Zhou
2024/06/18
Re: Review Request 75057: [link] Work around apparent MAC address bug
Benjamin Mahler
2024/06/18
Review Request 75057: [link] Work around apparent MAC address bug
Jason Zhou
2024/06/18
Re: Review Request 75056: [link] change link::setMAC return type to Try<Nothing>
Benjamin Mahler
2024/06/18
Review Request 75056: [link] change link::setMAC return type to Try<Nothing>
Jason Zhou
2024/06/12
Re: Review Request 75046: [route] use nl_addr_iszero helper fn when checking for destination IP network
Benjamin Mahler
2024/06/11
Re: Review Request 75046: [route] use nl_addr_iszero helper fn when checking for destination IP network
Jason Zhou
2024/06/11
Re: Review Request 75046: [route] use nl_addr_iszero helper fn when checking for destination IP network
Benjamin Mahler
2024/06/11
Review Request 75046: [route] use nl_addr_iszero helper fn when checking for destination IP network
Jason Zhou
2024/06/10
Re: Review Request 75044: [port_mapping] fix SmallEgressLimit test
Benjamin Mahler
2024/06/10
Re: Review Request 75043: [cgroups2] Fix control reaches end of non-void function
Benjamin Mahler
2024/06/10
Review Request 75043: [cgroups2] Fix control reaches end of non-void function
Jason Zhou
2024/06/10
Review Request 75044: [port_mapping] fix SmallEgressLimit test
Jason Zhou
2024/06/10
Re: Review Request 75042: [port-mapping] fix typo port_mapping.cpp
Benjamin Mahler
2024/06/10
Review Request 75042: [port-mapping] fix typo port_mapping.cpp
Jason Zhou
2024/06/07
Re: Review Request 75038: [port-mapping] cat back ip_local_port_range after updating ephemeral ports
Benjamin Mahler
2024/06/07
Review Request 75038: [port-mapping] cat back ip_local_port_range after updating ephemeral ports
Jason Zhou
2024/06/07
Re: Review Request 75037: [mesos-build] add /SRC/.git as safe directory for tidybot
Benjamin Mahler
2024/06/07
Re: Review Request 75036: [mesos-build] remove setting of environment variable in dockerfiles
Benjamin Mahler
2024/06/07
Review Request 75037: [mesos-build] add /SRC/.git as safe directory for tidybot
Jason Zhou
2024/06/07
Review Request 75036: [mesos-build] remove setting of environment variable in dockerfiles
Jason Zhou
2024/06/07
Re: Review Request 75035: [mesos-build] address dependency issues in centos-7 and ubuntu-20.04 dockerfiles
Benjamin Mahler
2024/06/07
[PR] CHANGE: add default network if no net options was set. [mesos]
via GitHub
2024/06/06
Re: Review Request 75032: [mesos-build] install openjdk 11 on ubuntu 20.04
Benjamin Mahler
2024/06/06
Review Request 75035: [mesos-build] install glibc.i686 on centos-7 to get an ELF interpreter
Jason Zhou
2024/06/05
Review Request 75032: install openjdk 11 on ubuntu 20.04
Jason Zhou
2024/06/05
Re: Review Request 75031: [mesos-build] add .git directory to safe directory
Benjamin Mahler
2024/06/05
Review Request 75031: [mesos-build] add .git directory to safe directory
Jason Zhou
2024/06/05
Re: Review Request 75030: [mesos-readme] clarify mesos-build instructions for uploading to dockerhub
Benjamin Mahler
2024/06/05
Re: Review Request 75029: [mesos-build] add correct directory to git safe directory & add explanation
Benjamin Mahler
2024/06/05
Review Request 75030: [mesos-readme] clarify mesos-build instructions for uploading to dockerhub
Jason Zhou
2024/06/05
Re: Review Request 75027: [mesos-build] update review tidybot & docker-build.sh to support ubuntu 20.04
Jason Zhou
2024/06/05
Review Request 75029: [mesos-build] add correct directory to git safe directory & add explanation
Jason Zhou
2024/06/04
Re: Review Request 75028: [mesos-build] add readme to support/mesos-build directory
Benjamin Mahler
2024/06/04
Re: Review Request 75027: [mesos-build] update review tidybot & docker-build.sh to support ubuntu 20.04
Benjamin Mahler
2024/06/04
Review Request 75028: [mesos-build] add readme to support/mesos-build directory
Jason Zhou
2024/06/04
Review Request 75027: [mesos-build] update review tidybot & docker-build.sh to support ubuntu 20.04
Jason Zhou
2024/06/03
Re: Review Request 75023: [mesos-build] Move mesos-build to from ubuntu 16.04 to 20.04
Benjamin Mahler
2024/06/03
Re: Review Request 75023: [mesos-build] Move mesos-build to from ubuntu 16.04 to 20.04
Jason Zhou
2024/06/03
Re: Review Request 75023: [mesos-build] Move mesos-build to from ubuntu 16.04 to 20.04
Benjamin Mahler
2024/06/03
Re: Review Request 75006: [cgroups2] Introduce the DeviceManagerProcess
Jason Zhou
2024/06/03
Review Request 75026: [cgroups2] update device configuration EBPF program generator
Jason Zhou
2024/05/30
Review Request 75023: [mesos-build] Mitigate missing bpf.h file info issues
Jason Zhou
2024/05/29
Re: [PR] Revert "Add support for docker network options" [mesos]
via GitHub
2024/05/29
[PR] Revert "Add support for docker network options" [mesos]
via GitHub
2024/05/29
Re: Review Request 75021: [cgroups2] remove dependency on ENABLE_CGROUPS_V2 macro
Benjamin Mahler
2024/05/29
Re: Review Request 75021: [cgroups2] remove dependency on ENABLE_CGROUPS_V2 macro
Benjamin Mahler
2024/05/29
Re: Review Request 75020: [mesos-build] Fix python setup in docker-build.sh
Mesos Reviewbot
2024/05/29
Review Request 75021: [cgroups2] remove dependency on ENABLE_CGROUPS_V2 macro
Jason Zhou
2024/05/29
Re: Review Request 75020: [mesos-build] Fix python setup in docker-build.sh
Benjamin Mahler
2024/05/29
Review Request 75020: [mesos-build] Fix python setup in docker-build.sh
Jason Zhou
2024/05/29
Re: [PR] Add support for docker network options [mesos]
via GitHub
2024/05/29
Re: Review Request 75006: [cgroups2] Introduce the DeviceManagerProcess
Benjamin Mahler
2024/05/29
Re: Review Request 75018: [cgroups2] check bpf.h existence on docker images & fix docker files
Benjamin Mahler
2024/05/29
Review Request 75018: [cgroups2] check bpf.h existence on docker images & fix docker files
Jason Zhou
2024/05/28
Re: Review Request 75016: [cgroups2] pass device manager to controllers & cgroups2 isolator
Mesos Reviewbot
2024/05/28
Review Request 75016: [cgroups2] pass device manager to controllers & cgroups2 isolator
Jason Zhou
2024/05/28
Re: Review Request 75006: [cgroups2] Introduce the DeviceManagerProcess
Mesos Reviewbot
2024/05/27
[PR] Add support for docker network options [mesos]
via GitHub
2024/05/24
Re: [PR] FIX: Add missing source file in cgroups list. [mesos]
via GitHub
2024/05/23
Re: Review Request 75010: [http] add test for executor_id support in /containers endpoint
Benjamin Mahler
2024/05/23
Re: Review Request 75009: [http] add support for executor_id and framework_id query parameters in /containers endpoint
Benjamin Mahler
2024/05/23
[PR] FIX: Add missing source file in cgroups list. [mesos]
via GitHub
2024/05/23
Re: [PR] FIX: mesos rpm add command and change mesos_isolation. [mesos]
via GitHub
2024/05/23
Re: Review Request 75011: [contributors] add self to contributors.yaml
Benjamin Mahler
2024/05/23
Re: Review Request 75010: [http] add test for executor_id support in /containers endpoint
Mesos Reviewbot
2024/05/23
Review Request 75011: [contributors] add self to contributors.yaml
Jason Zhou
2024/05/23
Review Request 75010: [http] add test for executor_id support in /containers endpoint
Jason Zhou
2024/05/23
Review Request 75009: [http] add support for executor_id parameter in /containers endpoint
Jason Zhou
Earlier messages
Later messages