> On May 14, 2015, 12:41 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 193 > > <https://reviews.apache.org/r/34137/diff/1/?file=957264#file957264line193> > > > > Not sure if I follow this logic or if I'm missing something, but the > > provisioners hashmap seems to be a local variable and I don't see anything > > populating it? And how will it contain anything?
This is to support the AppC provisioner in a later review, and subsequent provisioners. > On May 14, 2015, 12:41 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioner.hpp, line 35 > > <https://reviews.apache.org/r/34137/diff/1/?file=957265#file957265line35> > > > > What would recover do? Don't know actually, so I removed the TODO. If needed it'll be clear. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34137/#review83824 ----------------------------------------------------------- On May 12, 2015, 5:47 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34137/ > ----------------------------------------------------------- > > (Updated May 12, 2015, 5:47 p.m.) > > > Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > The MesosContainerizer can optionally provision a root filesystem for the > containers. > > > Diffs > ----- > > src/Makefile.am 14bc976a7b6a656fb58085484d25c3de3cf0f693 > src/slave/containerizer/mesos/containerizer.hpp > 3e18617b0dbac58176bfd41dc550898eb6a4a79e > src/slave/containerizer/mesos/containerizer.cpp > b644b9c74bc23cf78c0a53284544be6cdaef2f8a > src/slave/containerizer/provisioner.hpp PRE-CREATION > src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032 > src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932 > > Diff: https://reviews.apache.org/r/34137/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
