> On May 18, 2015, 4:38 p.m., Chi Zhang wrote: > > src/slave/containerizer/provisioners/appc/store.hpp, line 116 > > <https://reviews.apache.org/r/34140/diff/1/?file=957276#file957276line116> > > > > Looks like this is a global store for all images. Would it make sense > > to make sure at most one StoreProcess can be instantiated?
There should only be one Store for a given store directory, not necessarily globally. I don't think it's necessary to complicate the code to enforce uniqueness. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/#review84233 ----------------------------------------------------------- On May 12, 2015, 5:48 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34140/ > ----------------------------------------------------------- > > (Updated May 12, 2015, 5:48 p.m.) > > > Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Images are fetched into the store (after discovery). Stored images are > currently kept indefinitely. > > > Diffs > ----- > > src/Makefile.am 14bc976a7b6a656fb58085484d25c3de3cf0f693 > src/slave/containerizer/provisioners/appc/store.hpp PRE-CREATION > src/slave/containerizer/provisioners/appc/store.cpp PRE-CREATION > src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032 > src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932 > > Diff: https://reviews.apache.org/r/34140/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
