----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/#review83840 -----------------------------------------------------------
src/slave/containerizer/provisioners/appc/store.hpp <https://reviews.apache.org/r/34140/#comment134927> Is this suppose to be a generic Store? It returns a list of AppcImage but this is a generic namespace under slave. Should we have a base class like ContainerImage? src/slave/containerizer/provisioners/appc/store.cpp <https://reviews.apache.org/r/34140/#comment134949> Check exists first? src/slave/containerizer/provisioners/appc/store.cpp <https://reviews.apache.org/r/34140/#comment134950> Why not use os::rmdir? - Timothy Chen On May 26, 2015, 6:25 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34140/ > ----------------------------------------------------------- > > (Updated May 26, 2015, 6:25 p.m.) > > > Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Images are fetched into the store (after discovery). Stored images are > currently kept indefinitely. > > > Diffs > ----- > > src/Makefile.am 14bc976a7b6a656fb58085484d25c3de3cf0f693 > src/slave/containerizer/provisioners/appc/store.hpp PRE-CREATION > src/slave/containerizer/provisioners/appc/store.cpp PRE-CREATION > src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032 > src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932 > > Diff: https://reviews.apache.org/r/34140/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
