----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33271/#review86189 -----------------------------------------------------------
Ship it! docs/mesos-c++-style-guide.md <https://reviews.apache.org/r/33271/#comment138129> I totally didn't follow this. ;-) How about something as simple as: vector<string> strings{"hello"}; string& s = strings[0]; strings.erase(strings.begin()); s += "world"; // THIS IS A DANGLING REFERENCE! - Benjamin Hindman On June 2, 2015, 9:34 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33271/ > ----------------------------------------------------------- > > (Updated June 2, 2015, 9:34 a.m.) > > > Review request for mesos, Bernd Mathiske, Cody Maloney, Joerg Schad, Michael > Park, and Till Toenshoff. > > > Bugs: MESOS-2629 > https://issues.apache.org/jira/browse/MESOS-2629 > > > Repository: mesos > > > Description > ------- > > Follow up from r32630. > > > Diffs > ----- > > docs/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69 > > Diff: https://reviews.apache.org/r/33271/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
