reviews
Thread
Date
Earlier messages
Later messages
Messages by Thread
Re: Review Request 72409: Added intro docs on running workloads.
Greg Mann
Re: Review Request 72409: Added intro docs on running workloads.
Greg Mann
Re: Review Request 72409: Added intro docs on running workloads.
Qian Zhang
Re: Review Request 72409: Added intro docs on running workloads.
Qian Zhang
Re: Review Request 72409: Added intro docs on running workloads.
Greg Mann
Re: Review Request 72409: Added intro docs on running workloads.
Qian Zhang
Re: Review Request 72409: Added intro docs on running workloads.
Greg Mann
Re: Review Request 72409: Added intro docs on running workloads.
Qian Zhang
Re: Review Request 72409: Added intro docs on running workloads.
Greg Mann
Re: Review Request 72409: Added intro docs on running workloads.
Greg Mann
Re: Review Request 72409: Added intro docs on running workloads.
Qian Zhang
Review Request 72408: Made the scheduler resources a top-level item in the documentation.
Greg Mann
Re: Review Request 72408: Made the scheduler resources a top-level item in the documentation.
Qian Zhang
Re: Review Request 72408: Made the scheduler resources a top-level item in the documentation.
Greg Mann
Re: Review Request 72408: Made the scheduler resources a top-level item in the documentation.
Qian Zhang
Re: Review Request 72408: Made the scheduler resources a top-level item in the documentation.
Benjamin Mahler
Re: Review Request 72408: Made the scheduler resources a top-level item in the documentation.
Greg Mann
Review Request 72352: Fixed a bug where OpenSSLSocketImpl accept loop can silently stop.
Benjamin Mahler
Re: Review Request 72352: Fixed a bug where OpenSSLSocketImpl accept loop can silently stop.
Greg Mann
Re: Review Request 72352: Fixed a bug where OpenSSLSocketImpl accept loop can silently stop.
Benjamin Mahler
Re: Review Request 72352: Fixed a bug where OpenSSLSocketImpl accept loop can silently stop.
Benjamin Mahler
Re: Review Request 72352: Fixed a bug where OpenSSLSocketImpl accept loop can silently stop.
Greg Mann
Review Request 72404: Fixed discard race in libwinio io operations.
Benjamin Mahler
Re: Review Request 72404: Fixed discard race in libwinio io operations.
Greg Mann
Re: Review Request 72404: Fixed discard race in libwinio io operations.
Greg Mann
Re: Review Request 72404: Fixed discard race in libwinio io operations.
Benjamin Mahler
Re: Review Request 72404: Fixed discard race in libwinio io operations.
Benjamin Mahler
Review Request 72407: Enabled io::poll read test on Windows / added io::poll write test.
Benjamin Mahler
Re: Review Request 72407: Enabled io::poll read test on Windows / added io::poll write test.
Greg Mann
Review Request 72353: Added a regression test for MESOS-10114.
Benjamin Mahler
Re: Review Request 72353: Added a regression test for MESOS-10114.
Mesos Reviewbot
Re: Review Request 72353: Added a regression test for MESOS-10114.
Greg Mann
Re: Review Request 72353: Added a regression test for MESOS-10114.
Mesos Reviewbot
Review Request 72406: Fixed a bug where the openssl socket can block forever.
Benjamin Mahler
Re: Review Request 72406: Fixed a bug where the openssl socket can block forever.
Greg Mann
Review Request 72405: Added support for read readiness polling on Windows.
Benjamin Mahler
Re: Review Request 72405: Added support for read readiness polling on Windows.
Greg Mann
Re: Review Request 72405: Added support for read readiness polling on Windows.
Benjamin Mahler
Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.
Qian Zhang
Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.
Mesos Reviewbot
Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.
Qian Zhang
Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.
Qian Zhang
Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.
Mesos Reviewbot
Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.
Qian Zhang
Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.
Mesos Reviewbot
Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.
Qian Zhang
Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.
Mesos Reviewbot
Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.
Greg Mann
Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.
Qian Zhang
Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.
Qian Zhang
Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.
Mesos Reviewbot
Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.
Qian Zhang
Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.
Mesos Reviewbot
Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.
Greg Mann
Re: Review Request 72402: Updated Docker containerizer's `usage()` to support resource limits.
Mesos Reviewbot
Review Request 72401: Updated Docker containerizer by not updating resources for command task.
Qian Zhang
Re: Review Request 72401: Updated Docker containerizer by not updating resources for command task.
Qian Zhang
Re: Review Request 72401: Updated Docker containerizer by not updating resources for command task.
Qian Zhang
Re: Review Request 72401: Updated Docker containerizer by not updating resources for command task.
Greg Mann
Re: Review Request 72401: Updated Docker containerizer by not updating resources for command task.
Qian Zhang
Re: Review Request 72401: Updated Docker containerizer by not updating resources for command task.
Qian Zhang
Re: Review Request 72401: Updated Docker containerizer by not updating resources for command task.
Greg Mann
Review Request 72400: Updated `StatisticsEndpointRunningExecutor` to support resource limits.
Qian Zhang
Re: Review Request 72400: Updated `StatisticsEndpointRunningExecutor` to support resource limits.
Qian Zhang
Review Request 72399: Updated UCR's `usage()` method to support resource limits.
Qian Zhang
Re: Review Request 72399: Updated UCR's `usage()` method to support resource limits.
Qian Zhang
Re: Review Request 72399: Updated UCR's `usage()` method to support resource limits.
Qian Zhang
Re: Review Request 72399: Updated UCR's `usage()` method to support resource limits.
Qian Zhang
Re: Review Request 72399: Updated UCR's `usage()` method to support resource limits.
Qian Zhang
Re: Review Request 72399: Updated UCR's `usage()` method to support resource limits.
Greg Mann
Re: Review Request 72399: Updated UCR's `usage()` method to support resource limits.
Qian Zhang
Re: Review Request 72399: Updated UCR's `usage()` method to support resource limits.
Qian Zhang
Re: Review Request 72399: Updated UCR's `usage()` method to support resource limits.
Greg Mann
Re: Review Request 72399: Updated UCR's `usage()` method to support resource limits.
Qian Zhang
Review Request 72398: Updated `ResourceStatistics` to support container resource limits.
Qian Zhang
Re: Review Request 72398: Updated `ResourceStatistics` to support container resource limits.
Greg Mann
Re: Review Request 72398: Updated `ResourceStatistics` to support container resource limits.
Qian Zhang
Re: Review Request 72398: Added `cpus_soft_limit` field to `ResourceStatistics` protobuf message.
Qian Zhang
Re: Review Request 72398: Added `cpus_soft_limit` field to `ResourceStatistics` protobuf message.
Qian Zhang
Re: Review Request 72398: Added `cpus_soft_limit` field to `ResourceStatistics` protobuf message.
Qian Zhang
Re: Review Request 72398: Added `cpus_soft_limit` field to `ResourceStatistics` protobuf message.
Greg Mann
[GitHub] [mesos] bmahler commented on issue #359: Made the cgroup listener stop logging spurious error on finalization.
GitBox
Review Request 72390: Enabled `LoggingTest*` and `MetricTest*` on Windows.
Andrei Sekretenko
Re: Review Request 72390: Enabled `LoggingTest*` and `MetricTest*` on Windows.
Benjamin Mahler
Re: Review Request 72390: Enabled `LoggingTest*` and `MetricTest*` on Windows.
Mesos Reviewbot
Review Request 72389: Fixed composing authorization callback path on Windows.
Andrei Sekretenko
Re: Review Request 72389: Fixed composing authorization callback path on Windows.
Benjamin Mahler
Re: Review Request 72389: Fixed composing authorization callback path on Windows.
Andrei Sekretenko
Review Request 72391: Updated Docker containerizer to set Docker container's resource limits.
Qian Zhang
Re: Review Request 72391: Updated Docker containerizer to set Docker container's resource limits.
Mesos Reviewbot
Re: Review Request 72391: Updated Docker containerizer to set Docker container's resource limits.
Qian Zhang
Re: Review Request 72391: Updated Docker containerizer to set Docker container's resource limits.
Qian Zhang
Re: Review Request 72391: Updated Docker containerizer to set Docker container's resource limits.
Qian Zhang
Re: Review Request 72391: Updated Docker containerizer to set Docker container's resource limits.
Qian Zhang
Re: Review Request 72391: Updated Docker containerizer to set Docker container's resource limits.
Qian Zhang
Re: Review Request 72391: Updated Docker containerizer to set Docker container's resource limits.
Greg Mann
Re: Review Request 72391: Updated Docker containerizer to set Docker container's resource limits.
Qian Zhang
Re: Review Request 72391: Updated Docker containerizer to set Docker container's resource limits.
Qian Zhang
[GitHub] [mesos] cf-natali opened a new pull request #359: Made the cgroup listener stop logging spurious error on finalization.
GitBox
Review Request 72370: Fixed unreachable code warning for `cgroups::destroy`.
Andrei Budnik
Re: Review Request 72370: Fixed unreachable code warning for `cgroups::destroy`.
Mesos Reviewbot
Re: Review Request 72370: Fixed unreachable code warning for `cgroups::destroy`.
Benjamin Mahler
Review Request 72368: Fixed a bug in the agent's draining handler.
Greg Mann
Re: Review Request 72368: Fixed a bug in the agent's draining handler.
Mesos Reviewbot
Re: Review Request 72368: Fixed a bug in the agent's draining handler.
Andrei Sekretenko
Re: Review Request 72368: Fixed a bug in the agent's draining handler.
Greg Mann
Re: Review Request 72368: Fixed a bug in the agent's draining handler.
Greg Mann
Re: Review Request 72368: Fixed a bug in the agent's draining handler.
Greg Mann
Re: Review Request 72368: Fixed a bug in the agent's draining handler.
Mesos Reviewbot
Re: Review Request 72368: Fixed a bug in the agent's draining handler.
Andrei Sekretenko
Re: Review Request 72368: Fixed a bug in the agent's draining handler.
Greg Mann
Re: Review Request 72368: Fixed a bug in the agent's draining handler.
Greg Mann
Re: Review Request 72368: Fixed a bug in the agent's draining handler.
Andrei Sekretenko
Re: Review Request 72368: Fixed a bug in the agent's draining handler.
Greg Mann
Re: Review Request 72368: Fixed a bug in the agent's draining handler.
Greg Mann
Re: Review Request 72368: Fixed a bug in the agent's draining handler.
Greg Mann
Re: Review Request 72368: Fixed a bug in the agent's draining handler.
Andrei Sekretenko
Re: Review Request 72368: Fixed a bug in the agent's draining handler.
Greg Mann
[GitHub] [mesos] cf-natali opened a new pull request #358: Mention that tests should be run as root/admin in contribution guides.
GitBox
[GitHub] [mesos] bmahler commented on issue #358: Mention that tests should be run as root/admin in contribution guides.
GitBox
Review Request 72364: Added test for reactivation of a disconnected drained agent.
Andrei Sekretenko
Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.
Mesos Reviewbot
Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.
Andrei Sekretenko
Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.
Mesos Reviewbot
Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.
Andrei Sekretenko
Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.
Mesos Reviewbot
Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.
Greg Mann
Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.
Andrei Sekretenko
Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.
Andrei Sekretenko
Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.
Mesos Reviewbot
Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.
Andrei Sekretenko
Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.
Mesos Reviewbot
Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.
Greg Mann
Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.
Mesos Reviewbot
Review Request 72363: Fixed handling disconnected agents by REACTIVATE_AGENT call.
Andrei Sekretenko
Re: Review Request 72363: Fixed handling disconnected agents by REACTIVATE_AGENT call.
Greg Mann
Re: Review Request 72363: Fixed handling disconnected agents by REACTIVATE_AGENT call.
Andrei Sekretenko
Review Request 72362: WIP: Reproduce crash by ACCEPT of an offer for a disconnected agent.
Andrei Sekretenko
Re: Review Request 72362: WIP: Reproduce crash by ACCEPT of an offer for a disconnected agent.
Mesos Reviewbot
[GitHub] [mesos] Bo98 opened a new pull request #357: Fixed missing find_if namespace qualification
GitBox
[GitHub] [mesos] bmahler commented on issue #357: Fixed missing find_if namespace qualification
GitBox
[GitHub] [mesos] bmahler closed pull request #357: Fixed missing find_if namespace qualification
GitBox
Review Request 72355: WIP: Tested fix for race condition in the libevent SSL socket.
Greg Mann
Re: Review Request 72355: WIP: Tested fix for race condition in the libevent SSL socket.
Mesos Reviewbot
Review Request 72354: Fixed libevent SSL socket shutdown race condition.
Greg Mann
Re: Review Request 72354: Fixed libevent SSL socket shutdown race condition.
Benjamin Mahler
Re: Review Request 72354: Fixed libevent SSL socket shutdown race condition.
Greg Mann
Re: Review Request 72354: Fixed libevent SSL socket shutdown race condition.
Greg Mann
Review Request 72348: Added logging of peer address in LibeventSSLSocket accept failures.
Benjamin Mahler
Re: Review Request 72348: Added logging of peer address in LibeventSSLSocket accept failures.
Greg Mann
Re: Review Request 72348: Added logging of peer address in LibeventSSLSocket accept failures.
Benjamin Mahler
Re: Review Request 72348: Added logging of peer address in LibeventSSLSocket accept failures.
Greg Mann
Re: Review Request 72348: Added logging of peer address in LibeventSSLSocket accept failures.
Greg Mann
Review Request 72349: Added logging of peer address in OpenSSLSocket accept failures.
Benjamin Mahler
Re: Review Request 72349: Added logging of peer address in OpenSSLSocket accept failures.
Mesos Reviewbot
Re: Review Request 72349: Added logging of peer address in OpenSSLSocket accept failures.
Greg Mann
[GitHub] [mesos] cf-natali opened a new pull request #356: libprocess: check protobuf (de)serialisation success.
GitBox
[GitHub] [mesos] bmahler commented on issue #356: libprocess: check protobuf (de)serialisation success.
GitBox
[GitHub] [mesos] cf-natali commented on issue #356: libprocess: check protobuf (de)serialisation success.
GitBox
[GitHub] [mesos] bmahler commented on issue #356: libprocess: check protobuf (de)serialisation success.
GitBox
[GitHub] [mesos] bmahler commented on a change in pull request #356: libprocess: check protobuf (de)serialisation success.
GitBox
[GitHub] [mesos] bmahler commented on a change in pull request #356: libprocess: check protobuf (de)serialisation success.
GitBox
[GitHub] [mesos] cf-natali commented on a change in pull request #356: libprocess: check protobuf (de)serialisation success.
GitBox
[GitHub] [mesos] cf-natali commented on a change in pull request #356: libprocess: check protobuf (de)serialisation success.
GitBox
[GitHub] [mesos] cf-natali commented on issue #356: libprocess: check protobuf (de)serialisation success.
GitBox
[GitHub] [mesos] cf-natali commented on issue #356: libprocess: check protobuf (de)serialisation success.
GitBox
[GitHub] [mesos] bmahler commented on issue #356: libprocess: check protobuf (de)serialisation success.
GitBox
[GitHub] [mesos] bmahler closed pull request #356: libprocess: check protobuf (de)serialisation success.
GitBox
Review Request 72315: Introduced test for `addSlave()` with maintenance and unknown framework.
Andrei Sekretenko
Re: Review Request 72315: Introduced test for `addSlave()` with maintenance and unknown framework.
Mesos Reviewbot
Re: Review Request 72315: Introduced test for `addSlave()` with maintenance and unknown framework.
Benjamin Mahler
Re: Review Request 72315: Introduced test for `addSlave()` with maintenance and unknown framework.
Andrei Sekretenko
Re: Review Request 72315: Introduced test for `addSlave()` with maintenance and unknown framework.
Mesos Reviewbot
Review Request 72314: Skip not yet known framework IDs in `generateInverseOffers()`.
Andrei Sekretenko
Re: Review Request 72314: Skip not yet known framework IDs in `generateInverseOffers()`.
Benjamin Mahler
Re: Review Request 72314: Skip not yet known framework IDs in `generateInverseOffers()`.
Andrei Sekretenko
Review Request 72309: Updated CFS tests to avoid checking CPU usage.
Greg Mann
Re: Review Request 72309: Updated CFS tests to avoid checking CPU usage.
Greg Mann
Re: Review Request 72309: Updated CFS tests to avoid checking CPU usage.
Mesos Reviewbot
Re: Review Request 72309: Updated CFS tests to avoid checking CPU usage.
Qian Zhang
Re: Review Request 72309: Updated CFS tests to avoid checking CPU usage.
Greg Mann
Re: Review Request 72309: Updated CFS tests to avoid checking CPU usage.
Qian Zhang
Re: Review Request 72309: Updated CFS tests to avoid checking CPU usage.
Mesos Reviewbot
Review Request 72305: Sent appropriate task status reason when task over memory request.
Greg Mann
Re: Review Request 72305: Sent appropriate task status reason when task over memory request.
Greg Mann
Re: Review Request 72305: Sent appropriate task status reason when task over memory request.
Mesos Reviewbot
Re: Review Request 72305: Sent appropriate task status reason when task over memory request.
Qian Zhang
Re: Review Request 72305: Sent appropriate task status reason when task over memory request.
Greg Mann
Re: Review Request 72305: Sent appropriate task status reason when task over memory request.
Qian Zhang
Re: Review Request 72305: Sent appropriate task status reason when task over memory request.
Greg Mann
Re: Review Request 72305: Sent appropriate task status reason when task over memory request.
Mesos Reviewbot
Re: Review Request 72305: Sent appropriate task status reason when task over memory request.
Greg Mann
Re: Review Request 72305: Sent appropriate task status reason when task over memory request.
Qian Zhang
Re: Review Request 72305: Sent appropriate task status reason when task over memory request.
Mesos Reviewbot
Re: Review Request 72305: Sent appropriate task status reason when task over memory request.
Greg Mann
Re: Review Request 72305: Sent appropriate task status reason when task over memory request.
Mesos Reviewbot
Re: Review Request 72305: Sent appropriate task status reason when task over memory request.
Qian Zhang
Review Request 72297: Added agent-side validation for resource limits.
Greg Mann
Re: Review Request 72297: Added agent-side validation for resource limits.
Qian Zhang
Re: Review Request 72297: Added agent-side validation for resource limits.
Mesos Reviewbot
Earlier messages
Later messages