----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34687/#review86819 -----------------------------------------------------------
I made some minor comments below but I think a better way to do this is to *not* write custom masterinfo json <-> protobuf converters. I prefer we just add a new optional field (say ipAddress of type string). Then you can just leverage the already existing generic protobuf <-> json converters. src/common/http.cpp <https://reviews.apache.org/r/34687/#comment138912> Why do you need this temporary? src/common/parse.hpp <https://reviews.apache.org/r/34687/#comment138920> s/error out/return an error/ src/common/parse.hpp <https://reviews.apache.org/r/34687/#comment138921> s/result/info/ src/common/parse.hpp <https://reviews.apache.org/r/34687/#comment138923> "ips" sounds like multiple IPs though i know you meant it as IP as a string. just call it "ipString" src/common/parse.hpp <https://reviews.apache.org/r/34687/#comment138922> s/this/This/ - Vinod Kone On June 3, 2015, 9 p.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34687/ > ----------------------------------------------------------- > > (Updated June 3, 2015, 9 p.m.) > > > Review request for mesos, haosdent huang and Niklas Nielsen. > > > Bugs: MESOS-2340 > https://issues.apache.org/jira/browse/MESOS-2340 > > > Repository: mesos > > > Description > ------- > > Jira: MESOS-2340 > > This is a preliminary step to enabling JSON API > for Master Discovery via Zookeeper. > > We currently save the MasterInfo PB to ZK > serializing directly the binary data, so that > for clients to retrieve that information, they > need to either link up with libmesos or > obtain the PB definition (in mesos/mesos.proto). > > This change only provides the (de)serialization > utility methods and associated tests. > > > Diffs > ----- > > src/Makefile.am f2110a360b6e2a1e99e1d9630d5dfacfd818530a > src/common/http.hpp afce7fea334c7bfa57efc48c413bf906a2ebde32 > src/common/http.cpp 2ac7fba7a3aac913540f1b09768777393b79284a > src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 > src/tests/common/http_tests.cpp f087b2313a13c3199b70b3d7feb728e1449a52e7 > src/tests/common/parse_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/34687/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Marco Massenzio > >
