----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35033/#review87030 -----------------------------------------------------------
Ship it! src/linux/fs.hpp <https://reviews.apache.org/r/35033/#comment139289> I guess you copied the below for version of sys/mount.h Would it make sense to exactly state which distro/version this was from and which kernel versions accept all of them? src/linux/fs.hpp <https://reviews.apache.org/r/35033/#comment139291> The format suddenly changes towards these shift expressions - should we unify them to all look the same? e.g. 1 << 0, ... - Till Toenshoff On June 3, 2015, 10:53 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35033/ > ----------------------------------------------------------- > > (Updated June 3, 2015, 10:53 p.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > May be missing in sys/mount.h but supported by the kernel. > > > Diffs > ----- > > src/linux/fs.hpp d7832a4b3761c48be6c1ccef58a30ee31c70dc1b > > Diff: https://reviews.apache.org/r/35033/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >