> On June 24, 2015, 6:34 p.m., Jie Yu wrote: > > src/master/master.hpp, lines 630-651 > > <https://reviews.apache.org/r/35711/diff/4/?file=989196#file989196line630> > > > > Can you move this function to src/master/validation.hpp|cpp > > > > ``` > > namespace role { > > Option<Error> validate(const std::string& role); > > } > > ```
Because both master and slave need this check, I create src/common/validation.hpp|cpp . - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review89222 ----------------------------------------------------------- On June 27, 2015, 11:35 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35711/ > ----------------------------------------------------------- > > (Updated June 27, 2015, 11:35 a.m.) > > > Review request for mesos, Adam B and Jie Yu. > > > Bugs: MESOS-2210 > https://issues.apache.org/jira/browse/MESOS-2210 > > > Repository: mesos > > > Description > ------- > > Disallow special characters in role name. > > > Diffs > ----- > > src/Makefile.am a064d17a6b62e6e3c8e190135bcc8cbbb0051ed5 > src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 > src/common/validation.hpp PRE-CREATION > src/common/validation.cpp PRE-CREATION > src/master/flags.cpp 4377715029878cfee36f067e9c53c42b522b79d8 > src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0 > src/tests/common/validation_tests.cpp PRE-CREATION > src/tests/resources_tests.cpp 30c10f3246b807800985f20f8835090657a2d56e > > Diff: https://reviews.apache.org/r/35711/diff/ > > > Testing > ------- > > make -j8 check > > > Thanks, > > haosdent huang > >
