> On July 1, 2015, 3:45 p.m., Till Toenshoff wrote: > > When trying to apply locally, I get: > > ``` > > $ ./support/apply-review.sh 36071 > > 2015-07-01 17:43:28 URL:https://reviews.apache.org/r/36071/diff/raw/ > > [1338/1338] -> "36071.patch" [1] > > 36071.patch:15: new blank line at EOF. > > + > > error: missing binary patch data for > > 'docs/images/docker_containerizer_flow.jpg' > > error: binary patch does not apply to > > 'docs/images/docker_containerizer_flow.jpg' > > error: docs/images/docker_containerizer_flow.jpg: patch does not apply > > Failed to apply patch > > ``` > > Kapil Arya wrote: > Same here.
I'm not sure how do I add the binary data as git diff doesn't really show it. I've manually uploaded the jpg. So it's basically the added text + the new jpg. Please help take a look at both! - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36071/#review90052 ----------------------------------------------------------- On July 1, 2015, 1:07 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36071/ > ----------------------------------------------------------- > > (Updated July 1, 2015, 1:07 a.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till > Toenshoff. > > > Repository: mesos > > > Description > ------- > > Add flow diagram for docker containerizer. > > > Diffs > ----- > > docs/docker-containerizer.md 73f897780a0bb72ab092cb08186a228e3084e798 > docs/images/docker_containerizer_flow.jpg PRE-CREATION > > Diff: https://reviews.apache.org/r/36071/diff/ > > > Testing > ------- > > make > > > Thanks, > > Timothy Chen > >
