----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36071/#review90242 -----------------------------------------------------------
This diagram does seem to be missing some essential flow-diagram-elements. I would expect something more like /docs/images/fetch_flow.jpg here. As an example, we got a branching decision here which is "Is slave contained in Docker Container" which might show as a diamond. Likewise, the docker inspect should be a loop with a case decision (diamond again). The latter will add a level of detail I wish this diagram had as a whole -- more details please. - Till Toenshoff On July 1, 2015, 6:24 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36071/ > ----------------------------------------------------------- > > (Updated July 1, 2015, 6:24 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till > Toenshoff. > > > Repository: mesos > > > Description > ------- > > Add flow diagram for docker containerizer. > > > Diffs > ----- > > docs/docker-containerizer.md 73f897780a0bb72ab092cb08186a228e3084e798 > docs/images/docker_containerizer_flow.jpg PRE-CREATION > > Diff: https://reviews.apache.org/r/36071/diff/ > > > Testing > ------- > > make > > > File Attachments > ---------------- > > flow > > https://reviews.apache.org/media/uploaded/files/2015/07/01/49bd5b6c-510a-4c54-aa8e-e9ec3ebb2451__docker_containerizer_flow.jpg > > > Thanks, > > Timothy Chen > >
