> On July 8, 2015, 12:01 a.m., Adam B wrote: > > docs/network-isolation.md, line 79 > > <https://reviews.apache.org/r/36281/diff/1/?file=1001779#file1001779line79> > > > > Why is this a fixed constant limit? Seems like we might want to adjust > > this depending on how many containers are running, or give some containers > > more bandwidth than others. Why isn't this just another resource type > > (outbound network bandwidth) with a fixed total, where subsets can be > > reserved/claimed by different frameworks/tasks.
Outbound network bandwidth sounds like a reasonable future enhancement - do you want to raise a ticket? > On July 8, 2015, 12:01 a.m., Adam B wrote: > > docs/network-isolation.md, lines 70-73 > > <https://reviews.apache.org/r/36281/diff/1/?file=1001779#file1001779line70> > > > > Is 1024 a reasonable example ephemeral_ports_per_container? Your > > current example only allows 24 containers on that slave, which is extremely > > low. Maybe 16 ports per container would make more sense, yielding 1536 > > possible containers. Its a reasonable number for the kinds of services I see running on mesos, after all we don't churn through containers very quickly. > On July 8, 2015, 12:01 a.m., Adam B wrote: > > docs/network-isolation.md, lines 24-29 > > <https://reviews.apache.org/r/36281/diff/1/?file=1001779#file1001779line24> > > > > Do these dependencies need to be added to getting-started.md? I don't believe so since this is not a default configuration. - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/#review90827 ----------------------------------------------------------- On July 8, 2015, 12:03 a.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36281/ > ----------------------------------------------------------- > > (Updated July 8, 2015, 12:03 a.m.) > > > Review request for mesos, Ian Downes, Jie Yu, and Cong Wang. > > > Repository: mesos > > > Description > ------- > > Document per-container unique egress flows and network queueing statistics. > > > Diffs > ----- > > docs/home.md bc277910907c381c08835b6e9d485b27d6da5002 > docs/network-isolation.md PRE-CREATION > docs/network-monitoring.md 8889fb165cc70bc382be0c99de8d7748328abf57 > > Diff: https://reviews.apache.org/r/36281/diff/ > > > Testing > ------- > > Rendered at https://www.notehub.org/2015/7/7/network-isolation for review. > > > Thanks, > > Paul Brett > >
