----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/#review90857 -----------------------------------------------------------
Ship it! A few other minor nits, but I think we can commit this for 0.23.0-rc2. I'd even be willing to make some of the changes myself before committing. docs/network-monitoring.md (line 7) <https://reviews.apache.org/r/36281/#comment144013> s/running under/on/? s/which bind/those that bind/ docs/network-monitoring.md (line 15) <https://reviews.apache.org/r/36281/#comment144014> > "Mesos will automatically check for those kernel functionalities and will abort if they are not supported" Is this still true? docs/network-monitoring.md (line 67) <https://reviews.apache.org/r/36281/#comment144016> > "If it is necessary to reduce this range to free ports to be allocated by the slave, it can be configured by defining the new range in `etc/sysctl.conf` and rebooting to eliminate" In "free ports", I couldn't tell if "free" was supposed to be a verb or adjective. How about "If ports need to be set aside for slave containers, the host ephemeral port range can be updated in `etc/sysctl.conf`. Rebooting after the update will eliminate" docs/network-monitoring.md (lines 69 - 71) <https://reviews.apache.org/r/36281/#comment144015> This comment confused me. What you really mean is that the previous range was 32768-61000, but then you took away the first chunk for Mesos to use for its containers. ``` # Set aside 32768-57344 for Mesos containers. # net.ipv4.ip_local_port_range = 32768 61000 net.ipv4.ip_local_port_range = 57345 61000 ``` docs/network-monitoring.md (line 77) <https://reviews.apache.org/r/36281/#comment144017> Maybe insert a <br> before "`number of ephemeral_ports / ephemeral_ports_per_container`" so that it goes on a single line. docs/network-monitoring.md (line 79) <https://reviews.apache.org/r/36281/#comment144020> What is the default value of ephemeral_ports_per_container? (1024) docs/network-monitoring.md (line 92) <https://reviews.apache.org/r/36281/#comment144018> Remove indentation if you want this to render as a header. docs/network-monitoring.md (line 106) <https://reviews.apache.org/r/36281/#comment144021> We should only bother to include this flag if we set a non-default value. docs/network-monitoring.md (line 107) <https://reviews.apache.org/r/36281/#comment144019> Can't you just say `300MB` like in your description? Or does this flag only handle KB? - Adam B On July 7, 2015, 5:59 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36281/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 5:59 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, and Cong Wang. > > > Repository: mesos > > > Description > ------- > > Document per-container unique egress flows and network queueing statistics. > > > Diffs > ----- > > docs/home.md bc277910907c381c08835b6e9d485b27d6da5002 > docs/network-monitoring.md 8889fb165cc70bc382be0c99de8d7748328abf57 > > Diff: https://reviews.apache.org/r/36281/diff/ > > > Testing > ------- > > Rendered at https://www.notehub.org/2015/7/7/network-isolation for review. > > > Thanks, > > Paul Brett > >
