----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34141/#review91338 -----------------------------------------------------------
src/slave/containerizer/provisioners/appc/backend.hpp (lines 25 - 28) <https://reviews.apache.org/r/34141/#comment144904> Alphabetic order. src/slave/containerizer/provisioners/appc/backend.hpp (line 49) <https://reviews.apache.org/r/34141/#comment144691> s/image/images. src/slave/containerizer/provisioners/appc/backend.hpp (lines 98 - 99) <https://reviews.apache.org/r/34141/#comment144685> Indentation. src/slave/containerizer/provisioners/appc/backend.cpp (line 1) <https://reviews.apache.org/r/34141/#comment144693> Kill this line. src/slave/containerizer/provisioners/appc/backend.cpp (lines 20 - 28) <https://reviews.apache.org/r/34141/#comment144907> Reorder includes. src/slave/containerizer/provisioners/appc/backend.cpp (line 109) <https://reviews.apache.org/r/34141/#comment144713> Indentation. src/slave/containerizer/provisioners/appc/backend.cpp (lines 119 - 120) <https://reviews.apache.org/r/34141/#comment144722> Indentation. src/slave/containerizer/provisioners/appc/backend.cpp (line 130) <https://reviews.apache.org/r/34141/#comment144923> OSX [doesn't take this flag](https://developer.apple.com/library/mac/documentation/Darwin/Reference/ManPages/man1/cp.1.html). How about `-a`? src/slave/containerizer/provisioners/appc/backend.cpp (lines 147 - 156) <https://reviews.apache.org/r/34141/#comment144924> The style guilde requires: ``` // 2: OK (when no chaining, compare to 1). instance.method([]() { ...; }); ``` i.e. 2 space indentation for the body and have the closing brace aligned with the dot in ".then". src/slave/containerizer/provisioners/appc/backend.cpp (lines 179 - 188) <https://reviews.apache.org/r/34141/#comment144925> Ditto. - Jiang Yan Xu On July 7, 2015, 12:43 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34141/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 12:43 p.m.) > > > Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Simple copy backend that forms the rootfs by copying each layer. > > > Diffs > ----- > > src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 > src/slave/containerizer/provisioners/appc/backend.hpp PRE-CREATION > src/slave/containerizer/provisioners/appc/backend.cpp PRE-CREATION > src/slave/flags.hpp 7634e368c72e83932dcd992d78eaca146326606b > src/slave/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2 > > Diff: https://reviews.apache.org/r/34141/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
