----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36450/#review91795 -----------------------------------------------------------
include/mesos/mesos.proto (line 102) <https://reviews.apache.org/r/36450/#comment145445> s/ip/IP/ src/common/type_utils.cpp (line 131) <https://reviews.apache.org/r/36450/#comment145447> Is the order of query parameters important? Aren't these URLs equivalent? http://a.b.c/?k1=a&k2=b http://a.b.c/?k2=b&k1=a - Vinod Kone On July 15, 2015, 1:01 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36450/ > ----------------------------------------------------------- > > (Updated July 15, 2015, 1:01 a.m.) > > > Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-3012 > https://issues.apache.org/jira/browse/MESOS-3012 > > > Repository: mesos > > > Description > ------- > > To make the API more consistent, we'd like to have a single way to express a > network address. > Also would like a way to express an HTTP address (a URL), which may include a > path prefix. > > This also enables the message passing optimization in the scheduler driver > when receiving events, per MESOS-3012. > > > Diffs > ----- > > include/mesos/mesos.proto 1763129da535561503e89cbd8c4a371f8553d8d6 > include/mesos/type_utils.hpp e7bfe8ca60af945e76b5d85ab37cc97b17ff1b4a > src/common/type_utils.cpp 19f79b47539ab51a5dff97f381a44c679cf5ecaf > src/master/master.cpp b877676afa6f3833eb7d2fb06beeaa288bd8bd5d > src/tests/master_tests.cpp 57721b788d0c70f4c6f5cc44d87465f52a70b6c2 > > Diff: https://reviews.apache.org/r/36450/diff/ > > > Testing > ------- > > Modified the simplest test I could find for offers. > > > Thanks, > > Ben Mahler > >
