> On July 16, 2015, 6:41 p.m., Vinod Kone wrote: > >
Split the test apart. > On July 16, 2015, 6:41 p.m., Vinod Kone wrote: > > src/sched/sched.cpp, line 1393 > > <https://reviews.apache.org/r/36497/diff/1/?file=1011992#file1011992line1393> > > > > Why store both 'master' and 'masterInfo'? I think you can get rid of > > 'master'. Gets us away from having to make sure they are in sync. Done, pulled this out into a separate review. > On July 16, 2015, 6:41 p.m., Vinod Kone wrote: > > src/tests/scheduler_event_call_tests.cpp, line 59 > > <https://reviews.apache.org/r/36497/diff/1/?file=1011993#file1011993line59> > > > > Can you expand on the comment here? This test is a bit complicated and > > could use some comments on what you are doing and testing. Split the test per your other suggestion. > On July 16, 2015, 6:41 p.m., Vinod Kone wrote: > > src/tests/scheduler_event_call_tests.cpp, lines 83-84 > > <https://reviews.apache.org/r/36497/diff/1/?file=1011993#file1011993line83> > > > > Why are you doing this test? To get the framework id from the message, is there a better way? > On July 16, 2015, 6:41 p.m., Vinod Kone wrote: > > src/tests/scheduler_event_call_tests.cpp, lines 89-91 > > <https://reviews.apache.org/r/36497/diff/1/?file=1011993#file1011993line89> > > > > pull this below the expectation. Hm.. will require a sweep across all the tests here, so I'll punt since it's not posssible to do consistently in the tests (some tests require things from the event in the expectation). Ok? > On July 16, 2015, 6:41 p.m., Vinod Kone wrote: > > src/tests/scheduler_event_call_tests.cpp, line 101 > > <https://reviews.apache.org/r/36497/diff/1/?file=1011993#file1011993line101> > > > > s/call/message/ It's the call that I'm testing, not the message :) - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36497/#review91934 ----------------------------------------------------------- On July 15, 2015, 1:47 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36497/ > ----------------------------------------------------------- > > (Updated July 15, 2015, 1:47 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2910 > https://issues.apache.org/jira/browse/MESOS-2910 > > > Repository: mesos > > > Description > ------- > > This one is non-trivial, note that we follow MESOS-786 with the exception of > the 3rd case, since it is not possible and schedulers could not have possibly > relied on getting registered instead of re-registered in that case. > > We now need to store the MasterInfo coming from the detector, as it is not > provided in Event. > > > Diffs > ----- > > src/sched/sched.cpp e372a15db035f74d525561839b873ed659e2c33f > src/tests/scheduler_event_call_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/36497/diff/ > > > Testing > ------- > > Added a test. > > > Thanks, > > Ben Mahler > >
