----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36497/#review92116 -----------------------------------------------------------
Ship it! src/sched/sched.cpp (line 453) <https://reviews.apache.org/r/36497/#comment146054> there is no master UPID anymore. update the comment? src/sched/sched.cpp (line 465) <https://reviews.apache.org/r/36497/#comment146055> s/required/relied/ ? - Vinod Kone On July 17, 2015, 1:36 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36497/ > ----------------------------------------------------------- > > (Updated July 17, 2015, 1:36 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2910 > https://issues.apache.org/jira/browse/MESOS-2910 > > > Repository: mesos > > > Description > ------- > > This one is non-trivial, note that we follow MESOS-786 with the exception of > the 3rd case, since it is not possible and schedulers could not have possibly > relied on getting registered instead of re-registered in that case. > > We now need to store the MasterInfo coming from the detector, as it is not > provided in Event. > > > Diffs > ----- > > src/sched/sched.cpp 839fcbf0169fecf74fb17cab94fe4d35a1e20a10 > src/tests/scheduler_event_call_tests.cpp > cf6aa19a644580ff9d805e919763e9342d72677f > > Diff: https://reviews.apache.org/r/36497/diff/ > > > Testing > ------- > > Added a test. > > > Thanks, > > Ben Mahler > >