> On July 2, 2015, 1:48 a.m., Timothy Chen wrote: > > include/mesos/mesos.proto, line 1300 > > <https://reviews.apache.org/r/34142/diff/2/?file=989783#file989783line1300> > > > > I believe we discussed this, but different acVersion will most likely > > have different schema. > > > > Unless we intend to only support one version (or anything that's > > backward compatible), we should version the protobuf too. > > Timothy Chen wrote: > Actually at this point seems like AppC image spec most likely won't have > a new version with OCP, so perhaps we don't have to. I'll let you decide :)
We should at least say in the comment what acVersion this proto definiton is based on. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34142/#review90204 ----------------------------------------------------------- On July 7, 2015, 12:43 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34142/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 12:43 p.m.) > > > Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Discovers image(s), fetches to the image store, then provisions using > a backend. > > > Diffs > ----- > > include/mesos/mesos.proto 8df1211165169c9595e0e6e85b5ddc404345ff70 > src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 > src/slave/containerizer/mesos/containerizer.cpp > 8c102fb7d1f79ee768cb06de3a976ea12f958712 > src/slave/containerizer/provisioners/appc.hpp PRE-CREATION > src/slave/containerizer/provisioners/appc.cpp PRE-CREATION > src/slave/flags.hpp 7634e368c72e83932dcd992d78eaca146326606b > src/slave/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2 > > Diff: https://reviews.apache.org/r/34142/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
