----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/#review92514 -----------------------------------------------------------
Ship it! LGTM, thanks for adding much needed documentation too for the fields ! Upon reading the corresponding JIRA, I am assuming that we had an agreement to not use the Address field that BenM introduced in r36450 for readability of the field. include/mesos/mesos.proto (line 382) <https://reviews.apache.org/r/36663/#comment146724> Minor Nitpick : Did you refer to a "name;" here instead of "name:" - Anand Mazumdar On July 21, 2015, 10:50 p.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36663/ > ----------------------------------------------------------- > > (Updated July 21, 2015, 10:50 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-2736 > https://issues.apache.org/jira/browse/MESOS-2736 > > > Repository: mesos > > > Description > ------- > > As part of the new HTTP API and the need to > provide a better interface for clients that > do not integrate libmesos, we provide the IP > address of the Leader Master in string format; > this will eventually supersed the int32 existing > `ip`, which also cannot support IPv6 addresses. > > Jira: MESOS-2736 > > > Diffs > ----- > > include/mesos/mesos.proto bcb38d934c7f223b9a23746b273e581e0e8da886 > src/common/protobuf_utils.cpp 9ba57a73e44ddbebfc44d0de61ebefd1ab620209 > src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 > > Diff: https://reviews.apache.org/r/36663/diff/ > > > Testing > ------- > > make check > (also tested via [zk-mesos](https://github.com/massenz/zk-mesos) that the > information serialized to ZK is readable and as expected). > > > Thanks, > > Marco Massenzio > >
