> On July 21, 2015, 11:59 p.m., Anand Mazumdar wrote: > > LGTM, thanks for adding much needed documentation too for the fields ! > > > > Upon reading the corresponding JIRA, I am assuming that we had an agreement > > to not use the Address field that BenM introduced in r36450 for readability > > of the field.
Well, I summarized the alternatives and put forward my recommendation - that was on 6/15: there was no further comment since, so I acted on the principle of "lazy consensus". Also, please note that this will be serialized in JSON and the users of this are largely assumed NOT to use libmesos, so the benefits of the `Address` protobuf are very limited (in fact, it makes the generated JSON more difficult to parse and the entire structure more confusing; as I articulated in MESOS-2736) as we cannot remove existing fields without breaking backward compatibility, and the information would be repeated in difference places making the whole thing mightily confusing. > On July 21, 2015, 11:59 p.m., Anand Mazumdar wrote: > > include/mesos/mesos.proto, line 382 > > <https://reviews.apache.org/r/36663/diff/1/?file=1018235#file1018235line382> > > > > Minor Nitpick : Did you refer to a "name;" here instead of "name:" Thanks, you're right `;` works better. - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/#review92514 ----------------------------------------------------------- On July 21, 2015, 10:50 p.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36663/ > ----------------------------------------------------------- > > (Updated July 21, 2015, 10:50 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-2736 > https://issues.apache.org/jira/browse/MESOS-2736 > > > Repository: mesos > > > Description > ------- > > As part of the new HTTP API and the need to > provide a better interface for clients that > do not integrate libmesos, we provide the IP > address of the Leader Master in string format; > this will eventually supersed the int32 existing > `ip`, which also cannot support IPv6 addresses. > > Jira: MESOS-2736 > > > Diffs > ----- > > include/mesos/mesos.proto bcb38d934c7f223b9a23746b273e581e0e8da886 > src/common/protobuf_utils.cpp 9ba57a73e44ddbebfc44d0de61ebefd1ab620209 > src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 > > Diff: https://reviews.apache.org/r/36663/diff/ > > > Testing > ------- > > make check > (also tested via [zk-mesos](https://github.com/massenz/zk-mesos) that the > information serialized to ZK is readable and as expected). > > > Thanks, > > Marco Massenzio > >
