> On July 28, 2015, 5:58 a.m., Adam B wrote: > > Did you test this with java enabled as well? What about without > > `--with-protobuf=`? All four combinations still need to compile & pass the > > unit tests. > > haosdent huang wrote: > I only run it with --disable-java and --with_protobuf, let me test other > 3 combinations.
@adam-mesos, @marco I update the code and test steps, could you help review it again? Thank you in advance. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36811/#review93240 ----------------------------------------------------------- On July 29, 2015, 7:19 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36811/ > ----------------------------------------------------------- > > (Updated July 29, 2015, 7:19 a.m.) > > > Review request for mesos, Adam B and Marco Massenzio. > > > Bugs: MESOS-2480 > https://issues.apache.org/jira/browse/MESOS-2480 > > > Repository: mesos > > > Description > ------- > > Don't check protobuf jar when --disable-java flag. > > > Diffs > ----- > > configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 > > Diff: https://reviews.apache.org/r/36811/diff/ > > > Testing > ------- > > ../configure --with-protobuf=/usr/local --disable-java > make -j4 > make check > ``` > [----------] Global test environment tear-down > [==========] 644 tests from 91 test cases ran. (431596 ms total) > [ PASSED ] 644 tests. > ``` > > ../configure > make -j4 > make check > ``` > [----------] Global test environment tear-down > [==========] 685 tests from 98 test cases ran. (554759 ms total) > [ PASSED ] 685 tests. > ``` > > ../configure --disable-java > make -j4 > make check > ``` > [----------] Global test environment tear-down > [==========] 644 tests from 91 test cases ran. (427688 ms total) > [ PASSED ] 644 tests. > ``` > > ../configure --with-protobuf=/usr/local > make -j4 > make check > ``` > [----------] Global test environment tear-down > [==========] 685 tests from 98 test cases ran. (551493 ms total) > [ PASSED ] 685 tests. > ``` > > > Thanks, > > haosdent huang > >
