----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36811/#review93240 -----------------------------------------------------------
Did you test this with java enabled as well? What about without `--with-protobuf=`? All four combinations still need to compile & pass the unit tests. - Adam B On July 25, 2015, 1:23 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36811/ > ----------------------------------------------------------- > > (Updated July 25, 2015, 1:23 a.m.) > > > Review request for mesos, Adam B and Niklas Nielsen. > > > Bugs: MESOS-2480 > https://issues.apache.org/jira/browse/MESOS-2480 > > > Repository: mesos > > > Description > ------- > > Don't check protobuf jar when --disable-java flag. > > > Diffs > ----- > > configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 > > Diff: https://reviews.apache.org/r/36811/diff/ > > > Testing > ------- > > ../configure --with-protobuf=/usr/local --disable-java > make -j4 > make check -j4 GTEST_FILTER=-"*" > > > Thanks, > > haosdent huang > >