> On July 30, 2015, 12:49 a.m., Vinod Kone wrote: > >
Kept the validation error composition per our offline discussion, returning for each case individually led to really verbose code, and we looked at using a lambda to leverage 'return', but this seemed to be the simplest route for now. > On July 30, 2015, 12:49 a.m., Vinod Kone wrote: > > src/master/master.cpp, lines 1574-1576 > > <https://reviews.apache.org/r/36927/diff/1/?file=1024921#file1024921line1574> > > > > so this line will be presented twice if principal is not set (which > > will be for most frameworks) because this function is called twice. that is > > kinda unfortunate and likely confusing to users. > > > > not sure what we could do here yet. Hm.. this is unfortunate, I've pulled it out into the caller code for now to avoid the double logging. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36927/#review93532 ----------------------------------------------------------- On July 29, 2015, 11:52 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36927/ > ----------------------------------------------------------- > > (Updated July 29, 2015, 11:52 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Framework authorization is now done through `authorizeFramework` which is > consistent with `authorizeTask`. > Also, `validateFrameworkAuthentication` captures the validation for > authentication. > > I also made registration and re-registration consistent: > > * Both perform the check for root submission, rather than just registration. > * Authentication checks in `_registerFramework` and `_reregisterFramework` > are now comprehensive (thanks to `validateFrameworkAuthentication`). > > > Diffs > ----- > > src/master/master.hpp 1135049d34f8ed4d56c795ad28c9ca1d07237b63 > src/master/master.cpp 2bfec2f69375444925252480142ee409b8474761 > > Diff: https://reviews.apache.org/r/36927/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
