----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36927/#review93657 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On July 30, 2015, 10:16 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36927/ > ----------------------------------------------------------- > > (Updated July 30, 2015, 10:16 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Framework authorization is now done through `authorizeFramework` which is > consistent with `authorizeTask`. > Also, `validateFrameworkAuthentication` captures the validation for > authentication. > > I also made registration and re-registration consistent: > > * Both perform the check for root submission, rather than just registration. > * Authentication checks in `_registerFramework` and `_reregisterFramework` > are now comprehensive (thanks to `validateFrameworkAuthentication`). > > > Diffs > ----- > > src/master/master.hpp 1135049d34f8ed4d56c795ad28c9ca1d07237b63 > src/master/master.cpp 8162b2b796c9712a7b2d544118fe8de2646a8d32 > > Diff: https://reviews.apache.org/r/36927/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
