----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review94040 -----------------------------------------------------------
3rdparty/libprocess/include/process/http.hpp (line 747) <https://reviews.apache.org/r/36847/#comment148544> This comment does not match the function signature. 3rdparty/libprocess/include/process/http.hpp (line 763) <https://reviews.apache.org/r/36847/#comment148545> s/pid/upid 3rdparty/libprocess/include/process/http.hpp (line 764) <https://reviews.apache.org/r/36847/#comment148546> Please explain what happens if it is none. 3rdparty/libprocess/include/process/http.hpp (line 765) <https://reviews.apache.org/r/36847/#comment148547> s/header/headers 3rdparty/libprocess/src/http.cpp (line 938) <https://reviews.apache.org/r/36847/#comment148548> Because of this concatenation we should explain at the function delcaration in http.hpp that it is expected that `path` starts with "/". Or is it not? - Bernd Mathiske On Aug. 3, 2015, 11:45 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36847/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2015, 11:45 a.m.) > > > Review request for mesos, Alexander Rukletsov and Bernd Mathiske. > > > Bugs: MESOS-3152 > https://issues.apache.org/jira/browse/MESOS-3152 > > > Repository: mesos > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > b8d930058aa3ae9d21ae0f7b420d49f2448f84b1 > 3rdparty/libprocess/src/http.cpp 4dcbd74b894b483c4d166c23fac55ac8dba75166 > 3rdparty/libprocess/src/tests/http_tests.cpp > ecbcbd552ac834659860627c82628ed38e6139b3 > > Diff: https://reviews.apache.org/r/36847/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
