----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review94388 -----------------------------------------------------------
3rdparty/libprocess/include/process/http.hpp (line 754) <https://reviews.apache.org/r/36847/#comment148965> I'm rather late to the party, but AFAIK Mesos appreciates consistency over doing some things right and some wrong. The Mesos way would be to add the method in a consistent way and then do a sweep change for all the other http calls. That being said, the way I have seen other http libraries getting around the keyword issue is by using an underscore at some point. - Alexander Rojas On Aug. 4, 2015, 12:57 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36847/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2015, 12:57 p.m.) > > > Review request for mesos, Alexander Rukletsov and Bernd Mathiske. > > > Bugs: MESOS-3152 > https://issues.apache.org/jira/browse/MESOS-3152 > > > Repository: mesos > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > b8d930058aa3ae9d21ae0f7b420d49f2448f84b1 > 3rdparty/libprocess/src/http.cpp 4dcbd74b894b483c4d166c23fac55ac8dba75166 > 3rdparty/libprocess/src/tests/http_tests.cpp > ecbcbd552ac834659860627c82628ed38e6139b3 > > Diff: https://reviews.apache.org/r/36847/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
