----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36811/#review94562 -----------------------------------------------------------
Patch looks great! Reviews applied: [36810, 36811] All tests passed. - Mesos ReviewBot On Aug. 7, 2015, 3:21 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36811/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2015, 3:21 p.m.) > > > Review request for mesos, Adam B, Cody Maloney, Michael Park, and Timothy St. > Clair. > > > Bugs: MESOS-2480 > https://issues.apache.org/jira/browse/MESOS-2480 > > > Repository: mesos > > > Description > ------- > > Don't check protobuf jar when --disable-java flag. > > > Diffs > ----- > > configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 > > Diff: https://reviews.apache.org/r/36811/diff/ > > > Testing > ------- > > ../configure --with-protobuf=/usr/local --disable-java > make -j4 > make check > ``` > [----------] Global test environment tear-down > [==========] 644 tests from 91 test cases ran. (431596 ms total) > [ PASSED ] 644 tests. > ``` > > ../configure > make -j4 > make check > ``` > [----------] Global test environment tear-down > [==========] 685 tests from 98 test cases ran. (554759 ms total) > [ PASSED ] 685 tests. > ``` > > ../configure --disable-java > make -j4 > make check > ``` > [----------] Global test environment tear-down > [==========] 644 tests from 91 test cases ran. (427688 ms total) > [ PASSED ] 644 tests. > ``` > > ../configure --with-protobuf=/usr/local > make -j4 > make check > ``` > [----------] Global test environment tear-down > [==========] 685 tests from 98 test cases ran. (551493 ms total) > [ PASSED ] 685 tests. > ``` > > > Thanks, > > haosdent huang > >
