> On Aug. 17, 2015, 9:59 p.m., Timothy Chen wrote: > > Hi haosdent, thanks for working on this but I think running the healthcheck > > outside of the container doesn't make much sense to me. > > I think we should try to run it inside of the container (docker exec), but > > since docker exec is introduced until few later versions we also need to > > check to make sure the right version is running on the slave.
got it. Let me update. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37505/#review95651 ----------------------------------------------------------- On Aug. 16, 2015, 9:12 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37505/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2015, 9:12 a.m.) > > > Review request for mesos, Adam B and Timothy Chen. > > > Bugs: MESOS-3136 > https://issues.apache.org/jira/browse/MESOS-3136 > > > Repository: mesos > > > Description > ------- > > Fix broken health check in docker executor. > > > Diffs > ----- > > src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 > src/launcher/executor.cpp 9fa7dcfc39a6706f545b3328e468d9cd25d603ae > src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea > > Diff: https://reviews.apache.org/r/37505/diff/ > > > Testing > ------- > > # Add a new test, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask > sudo ./bin/mesos-tests.sh > --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthyTask" --verbose > > > Thanks, > > haosdent huang > >
