----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37505/ -----------------------------------------------------------
(Updated Aug. 23, 2015, 9:44 a.m.) Review request for mesos, Adam B and Timothy Chen. Changes ------- Add a new test case. Bugs: MESOS-3136 https://issues.apache.org/jira/browse/MESOS-3136 Repository: mesos Description ------- Fix broken health check in docker executor. Diffs (updated) ----- include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 src/slave/containerizer/docker.cpp a17e4f21e7f5a1dfd47699ec84c7a48fd82294ad src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea Diff: https://reviews.apache.org/r/37505/diff/ Testing (updated) ------- # Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange # Docker health check command is run through "docker exec" sudo ./bin/mesos-tests.sh --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthyTask" --verbose sudo ./bin/mesos-tests.sh --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange" --verbose Thanks, haosdent huang