----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review96116 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp (line 17) <https://reviews.apache.org/r/37669/#comment151331> Since we are using just `std::min`, can't we simple use an `if` or `?:` to avoid including this file. There were some concerns previously about the build speed, etc. - Kapil Arya On Aug. 22, 2015, 2:10 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37669/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2015, 2:10 a.m.) > > > Review request for mesos, Isabel Jimenez and Timothy Chen. > > > Bugs: MESOS-2986 > https://issues.apache.org/jira/browse/MESOS-2986 > > > Repository: mesos > > > Description > ------- > > Ignore overflow components in version parsing. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp > 51010845e8885ac52ce88ec0deb6b65a81122cba > 3rdparty/libprocess/3rdparty/stout/tests/version_tests.cpp > e8f8358f3c113b4e21e30cb5e9d6a3d229191484 > > Diff: https://reviews.apache.org/r/37669/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
