> On Aug. 30, 2015, 1:47 a.m., Ben Mahler wrote: > > Is 1.7.0.fc22 legal semver? From what I can tell looking at > > http://semver.org/, it is not legal? > > > > (1) Could we also follow up with the docker folks to use legal semver > > versioning? > > (2) It would be nice if we could push the logic of the docker versioning > > cleanup to the caller, since it seems docker specific and stout's Version > > was intended to be used for semver, thoughts? :)
We can do that, but I'm not sure they will strictly adhere to that. If stout/version is meant just for semver then I think you're right we should cleanup before parsing its version then. Let me revert this patch as I've just merged this. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review97001 ----------------------------------------------------------- On Aug. 29, 2015, 12:22 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37669/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2015, 12:22 p.m.) > > > Review request for mesos, Isabel Jimenez and Timothy Chen. > > > Bugs: MESOS-2986 > https://issues.apache.org/jira/browse/MESOS-2986 > > > Repository: mesos > > > Description > ------- > > Ignore overflow components in version parsing. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp > 51010845e8885ac52ce88ec0deb6b65a81122cba > 3rdparty/libprocess/3rdparty/stout/tests/version_tests.cpp > e8f8358f3c113b4e21e30cb5e9d6a3d229191484 > > Diff: https://reviews.apache.org/r/37669/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
