> On 九月 1, 2015, 9:48 a.m., Alexander Rukletsov wrote: > > That's awesome, Guangya, thanks for doing this! > > > > Some high-level comments before we dive into wording: > > * We recently adopted a new style for public headers, please update the > > comments according to it > > (https://mesos.apache.org/documentation/latest/mesos-doxygen-style-guide/) > > * We definitely need one more native speaker to review the comments. I > > think Adam B (adam-mesos) can be a good fit. Mind adding him to the list of > > reviewers?
Thanks Alex, just add adam-mesos to review list, will update the RR based on the new style. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review97270 ----------------------------------------------------------- On 九月 1, 2015, 10:03 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37993/ > ----------------------------------------------------------- > > (Updated 九月 1, 2015, 10:03 a.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, and Michael Park. > > > Bugs: MESOS-2224 > https://issues.apache.org/jira/browse/MESOS-2224 > > > Repository: mesos > > > Description > ------- > > Add explanatory comments for Allocator interface > > > Diffs > ----- > > include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a > > Diff: https://reviews.apache.org/r/37993/diff/ > > > Testing > ------- > > > Thanks, > > Guangya Liu > >
