> On Aug. 26, 2015, 5:50 p.m., Till Toenshoff wrote: > > src/slave/containerizer/provisioners/docker/store.cpp, line 135 > > <https://reviews.apache.org/r/37197/diff/10/?file=1052420#file1052420line135> > > > > I am not a big fan of such magic numbers (referring to that '7'). How > > about following the pattern the fetcher is using here > > (src/slave/containerizer/fetcher.cpp)? > > > > > > ``` > > [...] > > namespace slave { > > > > static const string FILE_URI_PREFIX = "file://"; > > [...] > > > > if (strings::startsWith(imageUri, FILE_URI_PREFIX)) { > > imageUri = imageUri.substr(FILE_URI_PREFIX.size()); > > } > > ``` > > Till Toenshoff wrote: > Why exactly did you close this without fixing the issue or giving some > more insights on why you insist on magic numbers?
Sorry I dropped it because this code is removed later on. I opened up a new review that holds everything now. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/#review96496 ----------------------------------------------------------- On Aug. 27, 2015, 11:39 p.m., Lily Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37197/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 11:39 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, > and Timothy Chen. > > > Bugs: MESOS-2849 > https://issues.apache.org/jira/browse/MESOS-2849 > > > Repository: mesos > > > Description > ------- > > Stored images currently kept indefinitely. > > > Diffs > ----- > > src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 > src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION > src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 > src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 > > Diff: https://reviews.apache.org/r/37197/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Lily Chen > >