----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38253/#review98880 -----------------------------------------------------------
include/mesos/mesos.proto (line 820) <https://reviews.apache.org/r/38253/#comment155535> Let's add a comment about this field include/mesos/slave/oversubscription.proto (lines 46 - 47) <https://reviews.apache.org/r/38253/#comment155536> We need to add a comment about the semantics of executor_id vs container_id. For example, what happens if both is set? Or do they need to be set together? (Loooks like it from the code below) src/slave/slave.cpp (lines 4367 - 4368) <https://reviews.apache.org/r/38253/#comment155538> Style nit: ``` const ContainerID& containerId = kill.has_container_id() ? kill.container_id() : executor->containerId; ``` Also, what happens if the container id is wrong? Think we need to do some validation here. src/tests/oversubscription_tests.cpp (line 807) <https://reviews.apache.org/r/38253/#comment155551> s/to QoS Controller/to the QoS Controller/ src/tests/oversubscription_tests.cpp (line 859) <https://reviews.apache.org/r/38253/#comment155555> Mind adding a TODO about doing a full blown object comparison? - Niklas Nielsen On Sept. 14, 2015, 10:41 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38253/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2015, 10:41 a.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-2875 > https://issues.apache.org/jira/browse/MESOS-2875 > > > Repository: mesos > > > Description > ------- > > We should ensure that we are addressing the container which the QoS > controller intended to kill. Without this check, we may run into a scenario > where the executor has terminated and one with the same id has started in the > interim i.e. running in a different container than the one the QoS controller > targeted. > > This most likely requires us to add containerId to the ResourceUsage message > and encode the containerID in the QoS Correction message. > > > Diffs > ----- > > include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c > include/mesos/slave/oversubscription.proto > fa69a95689c8c75765f0800692655e8dde7dde33 > src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 > src/tests/oversubscription_tests.cpp > 0c5edafc139d9bfb6806d007a0af85e80893bb1a > > Diff: https://reviews.apache.org/r/38253/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Klaus Ma > >
