----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38031/#review98906 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (lines 89 - 90) <https://reviews.apache.org/r/38031/#comment155613> Typically, we would do something like: ```cpp typename std::enable_if<std::is_integral<T>::value && std::is_signed<T>::value, int>::type = 0 ``` 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (lines 96 - 97) <https://reviews.apache.org/r/38031/#comment155614> Same here. 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (lines 117 - 119) <https://reviews.apache.org/r/38031/#comment155616> Can we mention the `SIGNED` part as well? (`SIGNED_INTEGER` and `UNSIGNED_INTEGER`) or (`SIGNED` and `UNSIGNED`)? 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (line 125) <https://reviews.apache.org/r/38031/#comment155617> Is the `inline` necessary here? 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (line 126) <https://reviews.apache.org/r/38031/#comment155618> We typically call this `stream`. - Michael Park On Sept. 11, 2015, 5:42 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38031/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2015, 5:42 p.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Michael Park, and Vinod Kone. > > > Bugs: MESOS-3345 > https://issues.apache.org/jira/browse/MESOS-3345 > > > Repository: mesos > > > Description > ------- > > * Changes JSON::Number to keep track of whether it is floating, signed > integral, or unsigned integral. > * Changes how JSON::Number is stringified, to ensure that stringified doubles > are parsed as JSON doubles. > * Added one test for integer precision between String <-> JSON <-> Protobuf > conversions. > * Added one test for JSON::Number comparisons. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp > f28138c4682c41e94ab6c7641a78d66b2f9daa5f > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > 57d5fdf45273c620655b44b5f5572290cffa4bf6 > 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp > 850650c269e9be24c0f1ae81b8aa8725f8a0c151 > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp > c56d6a3098293eb3659b3066f10e875927ec3ac3 > > Diff: https://reviews.apache.org/r/38031/diff/ > > > Testing > ------- > > No testing done until the last patch in the chain. > > However, this patch does breaks some libprocess and mesos tests (because > JSON::Number is stored differently), which are fixed in the following two > reviews. > > > Thanks, > > Joseph Wu > >
