> On 九月 15, 2015, 7:01 p.m., Vinod Kone wrote: > > include/mesos/scheduler.hpp, line 272 > > <https://reviews.apache.org/r/37532/diff/13/?file=1064326#file1064326line272> > > > > Should we even bother adding this to the old API? Note that adding a > > new call to the driver will impose a upgrade dependency between schedulers > > and master (master first, libmesos for scheduler next, scheduler jar last) > > > > more importantly, add a comment here that scheduler should call > > reviveOffers() to resume getting offers.
I will consider adding this to old API in other patches. > On 九月 15, 2015, 7:01 p.m., Vinod Kone wrote: > > include/mesos/scheduler/scheduler.proto, line 173 > > <https://reviews.apache.org/r/37532/diff/13/?file=1064327#file1064327line173> > > > > period at the end. also, does this fit within 80 chars? Yes, it is 79 chars after adding the period. > On 九月 15, 2015, 7:01 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 1747 > > <https://reviews.apache.org/r/37532/diff/13/?file=1064329#file1064329line1747> > > > > you also need to add a case statement to master/http.cpp. This was handled in https://reviews.apache.org/r/38124/diff/1#index_header - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/#review99061 ----------------------------------------------------------- On 九月 5, 2015, 12:01 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37532/ > ----------------------------------------------------------- > > (Updated 九月 5, 2015, 12:01 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3037 > https://issues.apache.org/jira/browse/MESOS-3037 > > > Repository: mesos > > > Description > ------- > > This is just part of MESOS-3037, this patch only add the interface > of QUIESCE call. > > > Diffs > ----- > > include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd > include/mesos/scheduler/scheduler.proto > 89daf8a6b74057ee156b3ad691397e76fcb835b8 > src/master/master.hpp e1331851c19e3372a4a525dcfd7ba2a01c3e97a6 > src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac > src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 > > Diff: https://reviews.apache.org/r/37532/diff/ > > > Testing > ------- > > > Thanks, > > Guangya Liu > >
