> On Sept. 21, 2015, 11:27 p.m., Connor Doyle wrote: > > include/mesos/hook.hpp, line 129 > > <https://reviews.apache.org/r/38564/diff/1/?file=1078412#file1078412line129> > > > > Missing definite article: "within the slave".
I wanted to add it, but the hooks above don't. I know, that's not necessarily a good excuse :) - Felix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/#review99846 ----------------------------------------------------------- On Sept. 21, 2015, 11:22 p.m., Felix Abecassis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38564/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2015, 11:22 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-3366 > https://issues.apache.org/jira/browse/MESOS-3366 > > > Repository: mesos > > > Description > ------- > > Add a new callback enabling custom attribute discovery logic > > > Diffs > ----- > > include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 > src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f > src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a > src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c > src/slave/slave.cpp ad710d7b930a2f115d503ceb8f8fd7421ad30287 > src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 > > Diff: https://reviews.apache.org/r/38564/diff/ > > > Testing > ------- > > > Thanks, > > Felix Abecassis > >
