----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/#review102362 -----------------------------------------------------------
Ship it! Mind rebasing this, Felix? :) We can land this after fixing the few comments below include/mesos/hook.hpp (lines 129 - 133) <https://reviews.apache.org/r/38564/#comment159978> Let's wrap at 80 cols here and in comments below include/mesos/hook.hpp (line 134) <https://reviews.apache.org/r/38564/#comment159979> Let's rename this to 'slaveAttributesDecorator': here and in rest of patch src/tests/hook_tests.cpp (line 659) <https://reviews.apache.org/r/38564/#comment159977> Should we rename this test as you are testing both decorators here? If not, maybe create a seperate test for it. - Niklas Nielsen On Sept. 22, 2015, 9:32 a.m., Felix Abecassis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38564/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2015, 9:32 a.m.) > > > Review request for mesos, Connor Doyle and Niklas Nielsen. > > > Bugs: MESOS-3366 > https://issues.apache.org/jira/browse/MESOS-3366 > > > Repository: mesos > > > Description > ------- > > Add a new callback enabling custom attribute discovery logic > > > Diffs > ----- > > include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 > src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f > src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a > src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c > src/slave/slave.cpp 29865ece00fa8bff3054a7f8c87cbf93403405db > src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 > > Diff: https://reviews.apache.org/r/38564/diff/ > > > Testing > ------- > > > Thanks, > > Felix Abecassis > >