----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38584/#review100005 -----------------------------------------------------------
src/slave/containerizer/isolators/filesystem/linux.hpp (line 141) <https://reviews.apache.org/r/38584/#comment157077> is this proper accordng to style guide (Since this is a public method)? src/slave/containerizer/isolators/filesystem/linux.cpp (line 839) <https://reviews.apache.org/r/38584/#comment157080> const? src/slave/containerizer/provisioner/provisioner.cpp (line 414) <https://reviews.apache.org/r/38584/#comment157082> const? src/slave/containerizer/provisioner/provisioner.cpp (line 429) <https://reviews.apache.org/r/38584/#comment157083> const? - Jojy Varghese On Sept. 22, 2015, 12:58 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38584/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2015, 12:58 a.m.) > > > Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen. > > > Bugs: MESOS-3466 > https://issues.apache.org/jira/browse/MESOS-3466 > > > Repository: mesos > > > Description > ------- > > Added a few filesystem isolation and provisioning metrics. > > > Diffs > ----- > > src/slave/containerizer/isolators/filesystem/linux.hpp > 041af7b51cc7da933a929d3beb05c419321ddd73 > src/slave/containerizer/isolators/filesystem/linux.cpp > e821b27d5cba324e434132d884d25a526c11a9c5 > src/slave/containerizer/provisioner/backends/bind.cpp > d853b49891360fbc2eb46f2e7859fa296fd36beb > src/slave/containerizer/provisioner/provisioner.cpp > 213f8a6cbcfa198920dbb83c42e58e8aef6d6946 > src/tests/containerizer/filesystem_isolator_tests.cpp > e2eb049ae477578caeedaa4251f7ddf9028d3fb5 > > Diff: https://reviews.apache.org/r/38584/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
