> On Sept. 23, 2015, 12:48 a.m., Niklas Nielsen wrote: > > src/slave/containerizer/linux_launcher.cpp, line 197 > > <https://reviews.apache.org/r/38635/diff/1/?file=1081421#file1081421line197> > > > > Wouldn't the idomatic way be to use stout's file abstractions?
Which ones are you referring to specifically? This is the pattern used in the cgroups files. I did abstract some of this away into a systemd namespace. Please see my upcoming reviews. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/#review100109 ----------------------------------------------------------- On Sept. 22, 2015, 5:29 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38635/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2015, 5:29 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas > Nielsen, Thomas Rampelberg, and Timothy Chen. > > > Bugs: MESOS-3425 > https://issues.apache.org/jira/browse/MESOS-3425 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/linux_launcher.hpp > f6112c98ffcc46ebcaf5581e821d5481d2f6b494 > src/slave/containerizer/linux_launcher.cpp > fd0ffcf838a745ccd458d57821d358eceb85be26 > > Diff: https://reviews.apache.org/r/38635/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
